Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: net/dns/mdns_client_impl.cc

Issue 17922002: Add an explicit way of forcing the MDnsClient to listen on the network (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/mdns_client_impl.cc
diff --git a/net/dns/mdns_client_impl.cc b/net/dns/mdns_client_impl.cc
index 2c379e7d9bc21d8b5b32112ed1a5e34ac44618da..fa4d94e742aac3b54bfd8148b6b620e3ad5212c1 100644
--- a/net/dns/mdns_client_impl.cc
+++ b/net/dns/mdns_client_impl.cc
@@ -384,40 +384,27 @@ void MDnsClientImpl::Core::QueryCache(
MDnsClientImpl::MDnsClientImpl(
scoped_ptr<MDnsConnection::SocketFactory> socket_factory)
- : listen_refs_(0), socket_factory_(socket_factory.Pass()) {
+ : socket_factory_(socket_factory.Pass()) {
}
MDnsClientImpl::~MDnsClientImpl() {
}
-bool MDnsClientImpl::AddListenRef() {
- if (!core_.get()) {
- core_.reset(new Core(this, socket_factory_.get()));
- if (!core_->Init()) {
- core_.reset();
- return false;
- }
+bool MDnsClientImpl::StartListening() {
+ DCHECK(!core_.get());
+ core_.reset(new Core(this, socket_factory_.get()));
+ if (!core_->Init()) {
+ core_.reset();
+ return false;
}
- listen_refs_++;
return true;
}
-void MDnsClientImpl::SubtractListenRef() {
- listen_refs_--;
- if (listen_refs_ == 0) {
- base::MessageLoop::current()->PostTask(FROM_HERE, base::Bind(
- &MDnsClientImpl::Shutdown, base::Unretained(this)));
- }
-}
-
-void MDnsClientImpl::Shutdown() {
- // We need to check that new listeners haven't been created.
- if (listen_refs_ == 0) {
- core_.reset();
- }
+void MDnsClientImpl::StopListening() {
+ core_.reset();
}
-bool MDnsClientImpl::IsListeningForTests() {
+bool MDnsClientImpl::GetListening() const {
return core_.get() != NULL;
}
@@ -450,7 +437,6 @@ MDnsListenerImpl::MDnsListenerImpl(
bool MDnsListenerImpl::Start() {
DCHECK(!started_);
- if (!client_->AddListenRef()) return false;
started_ = true;
DCHECK(client_->core());
@@ -463,7 +449,6 @@ MDnsListenerImpl::~MDnsListenerImpl() {
if (started_) {
DCHECK(client_->core());
client_->core()->RemoveListener(this);
- client_->SubtractListenRef();
}
}

Powered by Google App Engine
This is Rietveld 408576698