Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1791953002: Move ResolutionCopier out of generated (Closed)

Created:
4 years, 9 months ago by Brian Wilkerson
Modified:
4 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2084 lines, -2082 lines) Patch
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 1 chunk +1420 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 2 chunks +2 lines, -1420 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 4 chunks +0 lines, -662 lines 0 comments Download
M pkg/analyzer/test/src/dart/ast/utilities_test.dart View 3 chunks +662 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 9 months ago (2016-03-12 17:55:02 UTC) #2
scheglov
LGTM
4 years, 9 months ago (2016-03-12 18:09:21 UTC) #3
Brian Wilkerson
4 years, 9 months ago (2016-03-12 18:52:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4978bd6ac9fc4cb55f0228ed981aa526c1b28278 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698