Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: dart/tools/testing/dart/test_options.dart

Issue 179173003: Refactor compiler and runtime configurations (command line tools command building). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Address comments, sorta. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tools/testing/dart/test_options.dart
diff --git a/dart/tools/testing/dart/test_options.dart b/dart/tools/testing/dart/test_options.dart
index 6e0a2a57c22d0e5a0287a00e2def80cd03535fe3..5fd9e81c84c1badbe4b1814d093c33eb2690e98b 100644
--- a/dart/tools/testing/dart/test_options.dart
+++ b/dart/tools/testing/dart/test_options.dart
@@ -712,10 +712,7 @@ Note: currently only implemented for dart2js.''',
// Adjust default timeout based on mode, compiler, and sometimes runtime.
if (configuration['timeout'] == -1) {
int compilerMulitiplier =
- new CompilerConfiguration(configuration).computeTimeoutMultiplier(
- isDebug: configuration['mode'] == 'debug',
- isChecked: configuration['checked'],
- isHostChecked: configuration['host_checked']);
+ new CompilerConfiguration(configuration).computeTimeoutMultiplier();
int runtimeMultiplier =
new RuntimeConfiguration(configuration).computeTimeoutMultiplier(
isDebug: configuration['mode'] == 'debug',

Powered by Google App Engine
This is Rietveld 408576698