Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: pkg/mdv/lib/src/bindings.dart

Issue 17917002: Continue updating MDV. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merged Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/mdv/test/element_bindings_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/mdv/lib/src/bindings.dart
diff --git a/pkg/mdv/lib/src/bindings.dart b/pkg/mdv/lib/src/bindings.dart
index a23da89ea92376ad82d58a4afbaac55b4c2bd37e..2b40671b5e23667fd008ede789ef86f0761f40e8 100644
--- a/pkg/mdv/lib/src/bindings.dart
+++ b/pkg/mdv/lib/src/bindings.dart
@@ -32,11 +32,29 @@ abstract class _InputBinding {
_eventSub.cancel();
}
+ static EventStreamProvider<Event> _checkboxEventType = () {
+ // Attempt to feature-detect which event (change or click) is fired first
+ // for checkboxes.
+ var div = new DivElement();
+ var checkbox = div.append(new InputElement());
+ checkbox.type = 'checkbox';
+ var fired = [];
+ checkbox.onClick.listen((e) {
+ fired.add(Element.clickEvent);
+ });
+ checkbox.onChange.listen((e) {
+ fired.add(Element.changeEvent);
+ });
+ checkbox.dispatchEvent(new MouseEvent('click', view: window));
+ // WebKit/Blink don't fire the change event if the element is outside the
+ // document, so assume 'change' for that case.
+ return fired.length == 1 ? Element.changeEvent : fired.first;
+ }();
static Stream<Event> _getStreamForInputType(InputElement element) {
switch (element.type) {
case 'checkbox':
- return element.onClick;
+ return _checkboxEventType.forTarget(element);
case 'radio':
case 'select-multiple':
case 'select-one':
« no previous file with comments | « no previous file | pkg/mdv/test/element_bindings_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698