Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 179163004: Have Document::topDocument() return a reference (Closed)

Created:
6 years, 9 months ago by Inactive
Modified:
6 years, 9 months ago
Reviewers:
adamk
CC:
blink-reviews, aandrey+blink_chromium.org, Rik, aboxhall, sof, eae+blinkwatch, dglazkov+blink, dmazzoni, adamk+blink_chromium.org, rwlbuis, Inactive
Visibility:
Public.

Description

Have Document::topDocument() return a reference Have Document::topDocument() return a reference instead of a pointer as it can never return null. This makes the calling code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167922

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M Source/core/accessibility/AXObjectCache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/accessibility/AXObjectCache.cpp View 2 chunks +4 lines, -4 lines 1 comment Download
M Source/core/accessibility/AXRenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 4 chunks +11 lines, -10 lines 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDialogElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 9 months ago (2014-02-26 16:54:33 UTC) #1
adamk
lgtm https://codereview.chromium.org/179163004/diff/1/Source/core/accessibility/AXObjectCache.cpp File Source/core/accessibility/AXObjectCache.cpp (left): https://codereview.chromium.org/179163004/diff/1/Source/core/accessibility/AXObjectCache.cpp#oldcode113 Source/core/accessibility/AXObjectCache.cpp:113: m_document = const_cast<Document*>(doc); Ha! Thanks for getting rid ...
6 years, 9 months ago (2014-02-26 17:30:51 UTC) #2
adamk
The CQ bit was checked by adamk@chromium.org
6 years, 9 months ago (2014-02-26 17:31:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/179163004/1
6 years, 9 months ago (2014-02-26 17:31:13 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-02-26 19:39:29 UTC) #5
Message was sent while issue was closed.
Change committed as 167922

Powered by Google App Engine
This is Rietveld 408576698