Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1791623002: Revert of Media Galleries Partial Deprecation: Remove image metadata & libexif. (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, Michael Moss, oshima+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Media Galleries Partial Deprecation: Remove image metadata & libexif. (patchset #6 id:100001 of https://codereview.chromium.org/1773233002/ ) Reason for revert: Causes build errors on official waterfall. https://bugs.chromium.org/p/chromium/issues/detail?id=593580 Original issue's description: > Media Galleries Partial Deprecation: Remove image metadata & libexif. > > Removing libexif is a great thing. > > It will remove a ~200KB DLL from Windows, Mac, and ChromeOS. It will remove bugs and security issues. > > BUG=542912, 577272 > > Committed: https://crrev.com/f3890c75101ff9b07f48aed992285cc45bf5b4d5 > Cr-Commit-Position: refs/heads/master@{#380306} TBR=phajdan.jr@chromium.org,rdevlin.cronin@chromium.org,thakis@chromium.org,tommycli@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=542912, 577272 Committed: https://crrev.com/0978e4ebde4a1c07f4e8da88cc9daa7732a63b1a Cr-Commit-Position: refs/heads/master@{#380852}

Patch Set 1 #

Patch Set 2 : Manual revert/rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1871 lines, -29 lines) Patch
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
M build/experimental/install-build-deps.py View 1 3 chunks +3 lines, -0 lines 0 comments Download
M build/install-build-deps.sh View 1 3 chunks +20 lines, -18 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.amd64 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.i386 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.mipsel View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.trusty.arm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.amd64 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.arm View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.i386 View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.mipsel View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-jessie.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-trusty.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome.isolate View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_utility.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/media_galleries.idl View 1 1 chunk +16 lines, -3 lines 0 comments Download
M chrome/installer/linux/sysroot_scripts/packagelist.wheezy.mipsel View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/media_metadata/test.js View 1 2 chunks +25 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/media_galleries/read_access/test.js View 1 2 chunks +23 lines, -0 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/tools/build/mac/TESTS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/unit_tests.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/utility/BUILD.gn View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/utility/media_galleries/image_metadata_extractor.h View 1 chunk +95 lines, -0 lines 0 comments Download
A chrome/utility/media_galleries/image_metadata_extractor.cc View 1 chunk +465 lines, -0 lines 0 comments Download
A chrome/utility/media_galleries/image_metadata_extractor_unittest.cc View 1 chunk +76 lines, -0 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.cc View 1 4 chunks +53 lines, -0 lines 0 comments Download
M testing/chromoting/chromoting_browser_tests.isolate View 1 chunk +1 line, -0 lines 0 comments Download
M testing/libfuzzer/fuzzers/BUILD.gn View 1 1 chunk +12 lines, -0 lines 0 comments Download
A + testing/libfuzzer/fuzzers/libexif_parser_fuzzer.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A third_party/libexif/BUILD.gn View 1 chunk +115 lines, -0 lines 0 comments Download
A + third_party/libexif/OWNERS View 1 1 chunk +0 lines, -1 line 0 comments Download
A third_party/libexif/README.chromium View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/libexif/README.security View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/libexif/chromium.patch View 1 chunk +571 lines, -0 lines 0 comments Download
A third_party/libexif/libexif.def View 1 chunk +145 lines, -0 lines 0 comments Download
A third_party/libexif/libexif.gyp View 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (4 generated)
erikchen
Created Revert of Media Galleries Partial Deprecation: Remove image metadata & libexif.
4 years, 9 months ago (2016-03-11 23:00:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791623002/1
4 years, 9 months ago (2016-03-11 23:01:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791623002/1
4 years, 9 months ago (2016-03-11 23:01:48 UTC) #3
Nico
please link to bot and paste build error
4 years, 9 months ago (2016-03-11 23:02:23 UTC) #4
Nico
(in the revert cl description, that is) On Fri, Mar 11, 2016 at 6:02 PM, ...
4 years, 9 months ago (2016-03-11 23:02:43 UTC) #5
Nico
(next time, i mean) On Fri, Mar 11, 2016 at 6:02 PM, Nico Weber <thakis@chromium.org> ...
4 years, 9 months ago (2016-03-11 23:02:55 UTC) #6
erikchen
On 2016/03/11 23:02:55, Nico wrote: > (next time, i mean) > > On Fri, Mar ...
4 years, 9 months ago (2016-03-11 23:04:30 UTC) #7
Nico
Oh, indeed. My brain filters out all the URLs in commit descriptions apparently (since most ...
4 years, 9 months ago (2016-03-11 23:06:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791623002/1
4 years, 9 months ago (2016-03-11 23:32:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791623002/1
4 years, 9 months ago (2016-03-12 00:02:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791623002/1
4 years, 9 months ago (2016-03-12 00:31:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/130146)
4 years, 9 months ago (2016-03-12 00:57:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791623002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791623002/300001
4 years, 9 months ago (2016-03-12 02:47:45 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:300001)
4 years, 9 months ago (2016-03-12 04:49:54 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 04:51:08 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0978e4ebde4a1c07f4e8da88cc9daa7732a63b1a
Cr-Commit-Position: refs/heads/master@{#380852}

Powered by Google App Engine
This is Rietveld 408576698