Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1791613002: Enable background compilation of regexp methods. Regexp functions may use indirect goto instruction… (Closed)

Created:
4 years, 9 months ago by srdjan
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable background compilation of regexp methods. Regexp functions may use indirect goto instruction. On ia32, this instruction looks up the entry point of code object in order to find its own entry point. This does not work if we disable code while the code is running. Instead we get the entry point from code's saved instruction. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/abd32a39e56dbf9fd3e52f71d576c5b6533496ec

Patch Set 1 #

Patch Set 2 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M runtime/vm/code_generator.cc View 1 2 chunks +1 line, -6 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
4 years, 9 months ago (2016-03-11 21:53:55 UTC) #2
rmacnak
LGTM
4 years, 9 months ago (2016-03-11 22:19:36 UTC) #3
srdjan
4 years, 9 months ago (2016-03-11 22:33:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
abd32a39e56dbf9fd3e52f71d576c5b6533496ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698