Issue 17916003: Temporary change to keep chrome happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17916003: Temporary change to keep chrome happy. (Closed)

Created:
7 years, 6 months ago by scroggo

Modified:
7 years, 5 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Temporary change to keep chrome happy. Add back in a version of the constructor taking a stream so that chrome can build until we switch chrome to using the factory. Will be reverted once chrome switches to using the factory. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=9823

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Prevent the playback from being deleted. #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	include/core/SkPicture.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/core/SkPicture.cpp	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scroggo

New patch up, fixing a bug where the playback was deleted by the temporary picture.

7 years, 5 months ago (2013-06-27 15:09:46 UTC) #3

scroggo

7 years, 5 months ago (2013-06-28 21:35:33 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r9823 (presubmit successful).

Expand Messages | Collapse Messages