Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp

Issue 1791543005: InPrePaint document state and PrePaintTreeWalk class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp b/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
similarity index 95%
rename from third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
rename to third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
index 22eb5bdbf61de29c17a1d02a88a0719a8bab20f6..fcc123b9d30cbdfe6c5dab071e59962b3b7d47f4 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp
@@ -15,9 +15,9 @@
namespace blink {
-class PaintPropertyTreeBuilderTest : public RenderingTest {
+class PrePaintTreeWalkTest : public RenderingTest {
public:
- PaintPropertyTreeBuilderTest()
+ PrePaintTreeWalkTest()
: RenderingTest(SingleChildFrameLoaderClient::create())
, m_originalSlimmingPaintV2Enabled(RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { }
@@ -51,7 +51,7 @@ private:
bool m_originalSlimmingPaintV2Enabled;
};
-TEST_F(PaintPropertyTreeBuilderTest, FixedPosition)
+TEST_F(PrePaintTreeWalkTest, FixedPosition)
{
loadTestData("fixed-position.html");
@@ -81,7 +81,7 @@ TEST_F(PaintPropertyTreeBuilderTest, FixedPosition)
EXPECT_EQ(scrollerProperties->overflowClip(), target2Properties->overflowClip()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, PositionAndScroll)
+TEST_F(PrePaintTreeWalkTest, PositionAndScroll)
{
loadTestData("position-and-scroll.html");
@@ -116,7 +116,7 @@ TEST_F(PaintPropertyTreeBuilderTest, PositionAndScroll)
EXPECT_EQ(frameView->contentClip(), absPosProperties->overflowClip()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, FrameScrollingTraditional)
+TEST_F(PrePaintTreeWalkTest, FrameScrollingTraditional)
{
setBodyInnerHTML("<style> body { height: 10000px; } </style>");
@@ -141,7 +141,7 @@ TEST_F(PaintPropertyTreeBuilderTest, FrameScrollingTraditional)
// Need to set it during test setup. Besides that, the test still won't work because
// root layer scrolling mode is not compatible with SPv2 at this moment.
// (Duplicate display item ID for FrameView and LayoutView.)
-TEST_F(PaintPropertyTreeBuilderTest, DISABLED_FrameScrollingRootLayerScrolls)
+TEST_F(PrePaintTreeWalkTest, DISABLED_FrameScrollingRootLayerScrolls)
{
document().settings()->setRootLayerScrolls(true);
@@ -162,7 +162,7 @@ TEST_F(PaintPropertyTreeBuilderTest, DISABLED_FrameScrollingRootLayerScrolls)
EXPECT_EQ(frameView->scrollTranslation(), layoutViewProperties->scrollTranslation()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, Perspective)
+TEST_F(PrePaintTreeWalkTest, Perspective)
{
loadTestData("perspective.html");
@@ -180,7 +180,7 @@ TEST_F(PaintPropertyTreeBuilderTest, Perspective)
EXPECT_EQ(perspectiveProperties->perspective(), innerProperties->paintOffsetTranslation()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, Transform)
+TEST_F(PrePaintTreeWalkTest, Transform)
{
loadTestData("transform.html");
@@ -193,7 +193,7 @@ TEST_F(PaintPropertyTreeBuilderTest, Transform)
EXPECT_EQ(document().view()->scrollTranslation(), transformProperties->paintOffsetTranslation()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, RelativePositionInline)
+TEST_F(PrePaintTreeWalkTest, RelativePositionInline)
{
loadTestData("relative-position-inline.html");
@@ -203,7 +203,7 @@ TEST_F(PaintPropertyTreeBuilderTest, RelativePositionInline)
EXPECT_EQ(document().view()->scrollTranslation(), inlineBlockProperties->paintOffsetTranslation()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, NestedOpacityEffect)
+TEST_F(PrePaintTreeWalkTest, NestedOpacityEffect)
{
setBodyInnerHTML(
"<div id='nodeWithoutOpacity'>"
@@ -233,7 +233,7 @@ TEST_F(PaintPropertyTreeBuilderTest, NestedOpacityEffect)
EXPECT_EQ(childWithOpacityProperties->effect(), greatGrandChildWithOpacityProperties->effect()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, TransformNodeDoesNotAffectEffectNodes)
+TEST_F(PrePaintTreeWalkTest, TransformNodeDoesNotAffectEffectNodes)
{
setBodyInnerHTML(
"<div id='nodeWithOpacity' style='opacity: 0.6'>"
@@ -260,7 +260,7 @@ TEST_F(PaintPropertyTreeBuilderTest, TransformNodeDoesNotAffectEffectNodes)
EXPECT_EQ(nullptr, grandChildWithOpacityProperties->transform());
}
-TEST_F(PaintPropertyTreeBuilderTest, EffectNodesAcrossStackingContext)
+TEST_F(PrePaintTreeWalkTest, EffectNodesAcrossStackingContext)
{
setBodyInnerHTML(
"<div id='nodeWithOpacity' style='opacity: 0.6'>"
@@ -287,7 +287,7 @@ TEST_F(PaintPropertyTreeBuilderTest, EffectNodesAcrossStackingContext)
EXPECT_EQ(nullptr, grandChildWithOpacityProperties->transform());
}
-TEST_F(PaintPropertyTreeBuilderTest, EffectNodesInSVG)
+TEST_F(PrePaintTreeWalkTest, EffectNodesInSVG)
{
setBodyInnerHTML(
"<svg id='svgRoot'>"
@@ -327,7 +327,7 @@ TEST_F(PaintPropertyTreeBuilderTest, EffectNodesInSVG)
EXPECT_EQ(textWithOpacityProperties->effect(), tspanWithOpacityProperties->effect()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, EffectNodesAcrossHTMLSVGBoundary)
+TEST_F(PrePaintTreeWalkTest, EffectNodesAcrossHTMLSVGBoundary)
{
setBodyInnerHTML(
"<div id='divWithOpacity' style='opacity: 0.2;'>"
@@ -352,7 +352,7 @@ TEST_F(PaintPropertyTreeBuilderTest, EffectNodesAcrossHTMLSVGBoundary)
EXPECT_EQ(svgRootWithOpacityProperties->effect(), rectWithOpacityProperties->effect()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, EffectNodesAcrossSVGHTMLBoundary)
+TEST_F(PrePaintTreeWalkTest, EffectNodesAcrossSVGHTMLBoundary)
{
setBodyInnerHTML(
"<svg id='svgRootWithOpacity' style='opacity: 0.3;'>"
@@ -379,7 +379,7 @@ TEST_F(PaintPropertyTreeBuilderTest, EffectNodesAcrossSVGHTMLBoundary)
EXPECT_EQ(foreignObjectWithOpacityProperties->effect(), spanWithOpacityProperties->effect()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, TransformNodesInSVG)
+TEST_F(PrePaintTreeWalkTest, TransformNodesInSVG)
{
setBodyInnerHTML(
"<style>"
@@ -423,7 +423,7 @@ TEST_F(PaintPropertyTreeBuilderTest, TransformNodesInSVG)
EXPECT_EQ(nullptr, rectWith2dTransformProperties->paintOffsetTranslation());
}
-TEST_F(PaintPropertyTreeBuilderTest, SVGRootPaintOffsetTransformNode)
+TEST_F(PrePaintTreeWalkTest, SVGRootPaintOffsetTransformNode)
{
setBodyInnerHTML(
"<style>body { margin: 0px; } </style>"
@@ -437,7 +437,7 @@ TEST_F(PaintPropertyTreeBuilderTest, SVGRootPaintOffsetTransformNode)
EXPECT_EQ(document().view()->scrollTranslation(), svgProperties->paintOffsetTranslation()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, TransformNodesAcrossSVGHTMLBoundary)
+TEST_F(PrePaintTreeWalkTest, TransformNodesAcrossSVGHTMLBoundary)
{
setBodyInnerHTML(
"<style> body { margin: 0px; } </style>"
@@ -460,7 +460,7 @@ TEST_F(PaintPropertyTreeBuilderTest, TransformNodesAcrossSVGHTMLBoundary)
EXPECT_EQ(svgWithTransformProperties->transform(), divWithTransformProperties->transform()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, FixedTransformAncestorAcrossSVGHTMLBoundary)
+TEST_F(PrePaintTreeWalkTest, FixedTransformAncestorAcrossSVGHTMLBoundary)
{
setBodyInnerHTML(
"<style> body { margin: 0px; } </style>"
@@ -490,7 +490,7 @@ TEST_F(PaintPropertyTreeBuilderTest, FixedTransformAncestorAcrossSVGHTMLBoundary
EXPECT_EQ(containerProperties->transform(), fixedProperties->paintOffsetTranslation()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, ControlClip)
+TEST_F(PrePaintTreeWalkTest, ControlClip)
{
setBodyInnerHTML(
"<style>"
@@ -512,7 +512,7 @@ TEST_F(PaintPropertyTreeBuilderTest, ControlClip)
EXPECT_EQ(frameView->contentClip(), buttonProperties->overflowClip()->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, BorderRadiusClip)
+TEST_F(PrePaintTreeWalkTest, BorderRadiusClip)
{
setBodyInnerHTML(
"<style>"
@@ -557,7 +557,7 @@ TEST_F(PaintPropertyTreeBuilderTest, BorderRadiusClip)
EXPECT_EQ(frameView->contentClip(), borderRadiusClip->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, TransformNodesAcrossSubframes)
+TEST_F(PrePaintTreeWalkTest, TransformNodesAcrossSubframes)
{
setBodyInnerHTML(
"<style>body { margin: 0; }</style>"
@@ -590,7 +590,7 @@ TEST_F(PaintPropertyTreeBuilderTest, TransformNodesAcrossSubframes)
EXPECT_EQ(divWithTransformProperties->transform(), iframePreTranslation->parent());
}
-TEST_F(PaintPropertyTreeBuilderTest, TransformNodesInTransformedSubframes)
+TEST_F(PrePaintTreeWalkTest, TransformNodesInTransformedSubframes)
{
setBodyInnerHTML(
"<style>body { margin: 0; }</style>"
@@ -631,7 +631,7 @@ TEST_F(PaintPropertyTreeBuilderTest, TransformNodesInTransformedSubframes)
EXPECT_EQ(divWithTransformTransform, divWithTransform.objectPaintProperties()->transform());
}
-TEST_F(PaintPropertyTreeBuilderTest, TreeContextClipByNonStackingContext)
+TEST_F(PrePaintTreeWalkTest, TreeContextClipByNonStackingContext)
{
// This test verifies the tree builder correctly computes and records the property tree context
// for a (pseudo) stacking context that is scrolled by a containing block that is not one of
@@ -654,7 +654,7 @@ TEST_F(PaintPropertyTreeBuilderTest, TreeContextClipByNonStackingContext)
EXPECT_EQ(nullptr, childProperties->localBorderBoxProperties()->effect);
}
-TEST_F(PaintPropertyTreeBuilderTest, TreeContextUnclipFromParentStackingContext)
+TEST_F(PrePaintTreeWalkTest, TreeContextUnclipFromParentStackingContext)
{
// This test verifies the tree builder correctly computes and records the property tree context
// for a (pseudo) stacking context that has a scrolling painting ancestor that is not its

Powered by Google App Engine
This is Rietveld 408576698