InPrePaint document state and PrePaintTreeWalk class

third_party/WebKit/Source/core/dom/DocumentLifecycle.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 50 matching lines @@
         AfterPerformLayout,
         LayoutClean,
 
         InCompositingUpdate,
         CompositingClean,
 
         InPaintInvalidation,
         PaintInvalidationClean,
 
         // When RuntimeEnabledFeatures::slimmingPaintV2Enabled.
-        InUpdatePaintProperties,
-        UpdatePaintPropertiesClean,
+        InPrePaintTreeWalk,

[pdr., 2016/03/12 04:04:24]

Nit: Can you update the comment in LayoutObject.h above objectPaintProperties
too?

[jbroman, 2016/03/14 15:05:15]

It becomes less obvious what this step is, now that it only describes when it
happens, rather than what it does.

Something like "If RuntimeEnabledFeatures::slimmingPaintV2Enabled, paint
property trees are build in this step. If (other condition), paint invalidation
happens during this step.".

[Xianzhu, 2016/03/14 18:56:04]

Changed the state name "InPrePaintTreeWalk" to "InPrePaint" and added comment:
        // In InPrePaint step, any data needed for painting are prepared.
        // When RuntimeEnabledFeatures::slimmingPaintV2Enabled, paint property
trees are built.
        // Otherwise these steps are not applicable.

Will add comment about paint invalidation when it is added in this step.

+        PrePaintTreeWalkClean,
 
-        // When RuntimeEnabledFeatures::slimmingPaintSynchronizedPaintingEnabled
-        // (implied by slimmingPaintV2Enabled).
         InPaint,
         PaintClean,
 
         // Once the document starts shutting down, we cannot return
         // to the style/layout/compositing states.
         Stopping,
         Stopped,
         Disposed,
     };
 
@@ skipping 91 matching lines @@
     int m_detachCount;
 };
 
 inline bool DocumentLifecycle::stateAllowsTreeMutations() const
 {
     // FIXME: We should not allow mutations in InPreLayout or AfterPerformLayout either,
     // but we need to fix MediaList listeners and plugins first.
     return m_state != InStyleRecalc
         && m_state != InPerformLayout
         && m_state != InCompositingUpdate
-        && m_state != InUpdatePaintProperties
+        && m_state != InPrePaintTreeWalk
         && m_state != InPaint;
 }
 
 inline bool DocumentLifecycle::stateAllowsLayoutTreeMutations() const
 {
     return m_detachCount || m_state == InStyleRecalc || m_state == InLayoutSubtreeChange;
 }
 
 inline bool DocumentLifecycle::stateAllowsLayoutTreeNotifications() const
 {
     return m_state == InLayoutSubtreeChange;
 }
 
 inline bool DocumentLifecycle::stateAllowsDetach() const
 {
     return m_state == VisualUpdatePending
         || m_state == InStyleRecalc
         || m_state == StyleClean
         || m_state == LayoutSubtreeChangeClean
         || m_state == InPreLayout
         || m_state == LayoutClean
         || m_state == CompositingClean
         || m_state == PaintInvalidationClean
-        || m_state == UpdatePaintPropertiesClean
+        || m_state == PrePaintTreeWalkClean
         || m_state == PaintClean
         || m_state == Stopping;
 }
 
 inline bool DocumentLifecycle::stateAllowsLayoutInvalidation() const
 {
     return m_state != InPerformLayout
         && m_state != InCompositingUpdate
         && m_state != InPaintInvalidation
-        && m_state != InUpdatePaintProperties
+        && m_state != InPrePaintTreeWalk
         && m_state != InPaint;
 }
 
 } // namespace blink
 
 #endif