Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1791513002: Fix compile on Windows swarming bot (Closed)

Created:
4 years, 9 months ago by borenet2
Modified:
4 years, 9 months ago
Reviewers:
kjlubick, borenet, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Run the bootstrap script #

Patch Set 3 : Fix skia repo isolate? #

Patch Set 4 : Try another fix #

Patch Set 5 : Re-fix again #

Patch Set 6 : Set CHROME_HEADLESS #

Patch Set 7 : Set SystemRoot #

Patch Set 8 : Add TEMP #

Patch Set 9 : Set TMP #

Patch Set 10 : Add cleanup on Win #

Patch Set 11 : Handle AccessDenied #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M infra/bots/common.py View 1 2 3 4 5 6 7 8 9 10 5 chunks +23 lines, -1 line 0 comments Download
M infra/bots/flavor/default_flavor.py View 1 2 chunks +14 lines, -2 lines 0 comments Download
M infra/bots/skia_repo.isolate View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
borenet
4 years, 9 months ago (2016-03-11 20:51:59 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791513002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791513002/200001
4 years, 9 months ago (2016-03-16 13:59:37 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 9 months ago (2016-03-16 13:59:38 UTC) #6
kjlubick
lgtm
4 years, 9 months ago (2016-03-16 14:05:19 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 14:14:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791513002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791513002/200001
4 years, 9 months ago (2016-03-16 14:25:51 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 14:27:09 UTC) #13
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/523fa2a332d9c621bb871337893270a2bde31ea1

Powered by Google App Engine
This is Rietveld 408576698