IndexedDB: Remove uses of WebKit API types from back-end code

IndexedDB: Remove uses of WebKit API types from back-end code

Clean up almost everything except for enums.

BUG=233361, 237267
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209048

[jsbell, 2013-06-26 18:29:43]

This CL depends on https://codereview.chromium.org/17840006/ (moving files
in_process_webkit -> indexed_db)

Please take a look?

[jsbell, 2013-06-26 18:53:18]

CCing jamesr who probably cares

[jamesr, 2013-06-26 20:08:25]

Awesome! lgtm and thank you.

https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:40: "An attempt was
made to add something to storage that exceeded the quota.";
shouldn't this go in a resources file somewhere?

[jsbell, 2013-06-26 20:14:27]

https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:40: "An attempt was
made to add something to storage that exceeded the quota.";
On 2013/06/26 20:08:25, jamesr wrote:
> shouldn't this go in a resources file somewhere?

Exception messages aren't localized. This particular string is copied from
DOMException.cpp in Blink. Alternately, we could pass an empty string through
and use that as a trigger to look up the message on the Blink side.

[jsbell, 2013-06-26 22:12:47]

https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):

https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
content/browser/indexed_db/indexed_db_dispatcher_host.cc:40: "An attempt was
made to add something to storage that exceeded the quota.";
On 2013/06/26 20:14:28, jsbell wrote:
> On 2013/06/26 20:08:25, jamesr wrote:
> > shouldn't this go in a resources file somewhere?
> 
> Exception messages aren't localized. This particular string is copied from
> DOMException.cpp in Blink. Alternately, we could pass an empty string through
> and use that as a trigger to look up the message on the Blink side.

Changed it to pass through blank messages if the front-end should fill in, and
call the 1 or 2 param version of WebIDBDatabaseError::create() as appropriate.

[alecflett, 2013-06-26 22:23:01]

On 2013/06/26 22:12:47, jsbell wrote:
>
https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
> File content/browser/indexed_db/indexed_db_dispatcher_host.cc (right):
> 
>
https://codereview.chromium.org/17915004/diff/1/content/browser/indexed_db/in...
> content/browser/indexed_db/indexed_db_dispatcher_host.cc:40: "An attempt was
> made to add something to storage that exceeded the quota.";
> On 2013/06/26 20:14:28, jsbell wrote:
> > On 2013/06/26 20:08:25, jamesr wrote:
> > > shouldn't this go in a resources file somewhere?
> > 
> > Exception messages aren't localized. This particular string is copied from
> > DOMException.cpp in Blink. Alternately, we could pass an empty string
through
> > and use that as a trigger to look up the message on the Blink side.
> 
> Changed it to pass through blank messages if the front-end should fill in, and
> call the 1 or 2 param version of WebIDBDatabaseError::create() as appropriate.

hurray, this is great.

lgtm

[jsbell, 2013-06-26 23:27:49]

Note to self: will require rebase after
https://codereview.chromium.org/17642005/ lands

[commit-bot: I haz the power, 2013-06-27 21:18:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jsbell@chromium.org/17915004/20001

[commit-bot: I haz the power, 2013-06-28 01:03:34]

Change committed as 209048