Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1791483004: Revert of Fix mini_installer to handle VS 2015 component builds (Closed)

Created:
4 years, 9 months ago by vmiura
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix mini_installer to handle VS 2015 component builds (patchset #1 id:1 of https://codereview.chromium.org/1787883005/ ) Reason for revert: Suspect this has caused Win32 builders to break. BUG=594322 Original issue's description: > Fix mini_installer to handle VS 2015 component builds > > The mini_installer needs to unpack more CRT DLLs now that we are using > VS 2015. This change supports that, while still being VS 2013 > compatible. > > TBR=gab@chromium.org > BUG=594294 > > Committed: https://crrev.com/9ec74cd783f5a5eff2d5750f3bd072d5a577e0e4 > Cr-Commit-Position: refs/heads/master@{#380833} TBR=dpranke@chromium.org,stanisc@chromium.org,gab@chromium.org,brucedawson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594294 Committed: https://crrev.com/76311f1cf896615df4fa82b8421ae81cec9b7873 Cr-Commit-Position: refs/heads/master@{#380838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/tools/build/win/create_installer_archive.py View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vmiura
Created Revert of Fix mini_installer to handle VS 2015 component builds
4 years, 9 months ago (2016-03-12 04:33:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483004/1
4 years, 9 months ago (2016-03-12 04:34:30 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-12 04:35:50 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76311f1cf896615df4fa82b8421ae81cec9b7873 Cr-Commit-Position: refs/heads/master@{#380838}
4 years, 9 months ago (2016-03-12 04:37:11 UTC) #6
brucedawson
On 2016/03/12 04:37:11, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 9 months ago (2016-03-12 06:16:02 UTC) #7
brucedawson
4 years, 9 months ago (2016-03-12 15:37:47 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1793753002/ by brucedawson@chromium.org.

The reason for reverting is: Suspect this was not the cause of Win32 builds
breaking, and I don't want developers hitting this mini_installer bug. If
reverting again please provide more details and a link to the breaks..

Powered by Google App Engine
This is Rietveld 408576698