Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1791483003:
Revert of Roll Clang 261368:262839 (Closed)
|
Created:
4 years, 9 months ago by Nico Modified:
4 years, 9 months ago Reviewers:
hans CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRevert of Roll Clang 261368:262839 (patchset #3 id:40001 of https://codereview.chromium.org/1764413002/ )
Reason for revert:
The new compiler has an infinite loop for some inputs, see crbug.com/594142. This is not a good property for a compiler to have.
Original issue's description:
> Roll Clang 261368:262839
>
> BUG=589647
>
> Committed: https://crrev.com/d2af39c0b6518f0fc3be885fbc7edabe9bfa8272
> Cr-Commit-Position: refs/heads/master@{#380427}
TBR=hans@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=589647
Committed: https://crrev.com/b19267540b226944dea3d88322025181da554c4f
Cr-Commit-Position: refs/heads/master@{#380859}
Patch Set 1 #
Messages
Total messages: 17 (1 generated)
Created Revert of Roll Clang 261368:262839
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791483003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791483003/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Revert of Roll Clang 261368:262839 (patchset #3 id:40001 of https://codereview.chromium.org/1764413002/ ) Reason for revert: The new compiler has an infinite loop for some inputs, see crbug.com/594142. This is not a good property for a compiler to have. Original issue's description: > Roll Clang 261368:262839 > > BUG=589647 > > Committed: https://crrev.com/d2af39c0b6518f0fc3be885fbc7edabe9bfa8272 > Cr-Commit-Position: refs/heads/master@{#380427} TBR=hans@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589647 ========== to ========== Revert of Roll Clang 261368:262839 (patchset #3 id:40001 of https://codereview.chromium.org/1764413002/ ) Reason for revert: The new compiler has an infinite loop for some inputs, see crbug.com/594142. This is not a good property for a compiler to have. Original issue's description: > Roll Clang 261368:262839 > > BUG=589647 > > Committed: https://crrev.com/d2af39c0b6518f0fc3be885fbc7edabe9bfa8272 > Cr-Commit-Position: refs/heads/master@{#380427} TBR=hans@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589647 Committed: https://crrev.com/b19267540b226944dea3d88322025181da554c4f Cr-Commit-Position: refs/heads/master@{#380859} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b19267540b226944dea3d88322025181da554c4f Cr-Commit-Position: refs/heads/master@{#380859} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
