Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1791443002: Fix JPEGImageEncoder memory leak (Closed)

Created:
4 years, 9 months ago by xlai (Olivia)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix JPEGImageEncoder memory leak BUG=590648, 593435 Committed: https://crrev.com/1d2c4fd40b3c03ca7a016895bd9956aaad865c9a Cr-Commit-Position: refs/heads/master@{#380978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -48 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 chunk +7 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.cpp View 3 chunks +44 lines, -45 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
xlai (Olivia)
noel@: This CL is exactly the same as the last patch set as the previous ...
4 years, 9 months ago (2016-03-11 15:04:02 UTC) #3
Noel Gordon
Thank you. I will modify the change description slightly ...
4 years, 9 months ago (2016-03-11 16:42:43 UTC) #4
Noel Gordon
... actually it seems fine.
4 years, 9 months ago (2016-03-11 16:43:39 UTC) #5
Noel Gordon
LGTM. You'll need junov@ to approve the /CanvasAsyncBlobCreator.cpp change, but those changes look good to ...
4 years, 9 months ago (2016-03-11 16:45:33 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791443002/1
4 years, 9 months ago (2016-03-11 16:49:33 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/195529)
4 years, 9 months ago (2016-03-11 19:10:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791443002/1
4 years, 9 months ago (2016-03-14 14:17:16 UTC) #14
Justin Novosad
core lgtm
4 years, 9 months ago (2016-03-14 14:30:18 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791443002/1
4 years, 9 months ago (2016-03-14 14:31:30 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-14 15:35:11 UTC) #20
commit-bot: I haz the power
4 years, 9 months ago (2016-03-14 15:36:38 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1d2c4fd40b3c03ca7a016895bd9956aaad865c9a
Cr-Commit-Position: refs/heads/master@{#380978}

Powered by Google App Engine
This is Rietveld 408576698