Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: src/hydrogen.cc

Issue 17914002: First simplistic implementation of escape analysis. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed offline comments by Ben Titzer. Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index b03bf699389be7864587415c6143280159f27979..3932cebef4ff4d6f93e3421987c20f1b23482130 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -26,7 +26,6 @@
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#include "hydrogen.h"
-#include "hydrogen-gvn.h"
#include <algorithm>
@@ -35,6 +34,8 @@
#include "full-codegen.h"
#include "hashmap.h"
#include "hydrogen-environment-liveness.h"
+#include "hydrogen-escape-analysis.h"
+#include "hydrogen-gvn.h"
#include "lithium-allocator.h"
#include "parser.h"
#include "scopeinfo.h"
@@ -3983,6 +3984,7 @@ bool HGraph::Optimize(SmartArrayPointer<char>* bailout_reason) {
}
PropagateDeoptimizingMark();
+
titzer 2013/06/28 12:40:55 Whitespace change
Michael Starzinger 2013/06/28 13:37:27 Done.
if (!CheckConstPhiUses()) {
*bailout_reason = SmartArrayPointer<char>(StrDup(
"Unsupported phi use of const variable"));
@@ -4029,6 +4031,11 @@ bool HGraph::Optimize(SmartArrayPointer<char>* bailout_reason) {
if (FLAG_use_canonicalizing) Canonicalize();
+ if (FLAG_use_escape_analysis) {
+ HEscapeAnalysis escapeAnalysis(this);
Jakob Kummerow 2013/06/28 12:34:26 nit: unix_hacker_style for variable names
Michael Starzinger 2013/06/28 12:39:37 Done (also for the range analysis below).
+ escapeAnalysis.Analyze();
+ }
+
if (FLAG_use_gvn) GlobalValueNumbering();
if (FLAG_use_range) {
« no previous file with comments | « src/hydrogen.h ('k') | src/hydrogen-escape-analysis.h » ('j') | src/hydrogen-escape-analysis.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698