Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1791383003: Add sharing flag to file open during unsafe image test. (Closed)

Created:
4 years, 9 months ago by forshaw
Modified:
4 years, 9 months ago
Reviewers:
Nico, Will Harris
CC:
chromium-reviews, gavinp+memory_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add sharing flag to file open during unsafe image test. This fixes an issue with the unsafe image test when it's run concurrently. Without the sharing flag the open can sometimes fails depending on timing which makes the test flaky. BUG=594462 Committed: https://crrev.com/699c5f99ffcda70498cf94ba01948261ce5a700d Cr-Commit-Position: refs/heads/master@{#382128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/memory/shared_memory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
forshaw
Nico, could you please take a look at this short CL to fix a flaky ...
4 years, 9 months ago (2016-03-14 08:08:46 UTC) #2
Will Harris
lgtm
4 years, 9 months ago (2016-03-14 22:45:58 UTC) #3
Nico
lgtm
4 years, 9 months ago (2016-03-18 22:36:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1791383003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1791383003/1
4 years, 9 months ago (2016-03-18 22:37:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 23:17:19 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 23:18:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/699c5f99ffcda70498cf94ba01948261ce5a700d
Cr-Commit-Position: refs/heads/master@{#382128}

Powered by Google App Engine
This is Rietveld 408576698