Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179123009: Encrypted Media: Use uint32 for systemCode in SessionError. (Closed)

Created:
6 years, 9 months ago by xhwang
Modified:
6 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, fischman+watch_chromium.org, noelallen1, jam, mcasas+watch_chromium.org, yzshen+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, nfullagar1, piman+watch_chromium.org, wjia+watch_chromium.org, binji, ihf+watch_chromium.org
Visibility:
Public.

Description

Encrypted Media: Use uint32 for systemCode in SessionError. In prefixed EME spec, "systemCode" is an unsigned short (16bit unsigned integer). In unprefixed EME spec, it's an unsigned long (32bit unsigned integer). This CL updates "system_code" parameters in SessionError to use uint32. TBR=dcheng@chromium.org BUG=224786 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254693

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : comments addressed #

Patch Set 4 : comments addressed #

Patch Set 5 : comments addressed #

Patch Set 6 : comments addressed #

Total comments: 2

Patch Set 7 : comments addressed #

Patch Set 8 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -109 lines) Patch
M content/browser/media/android/browser_media_player_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/android/browser_media_player_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/cdm_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/proxy_media_keys.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/proxy_media_keys.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/renderer_media_player_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M content/renderer/media/cdm_session_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/cdm_session_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/crypto/proxy_decryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webcontentdecryptionmodulesession_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/webcontentdecryptionmodulesession_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_impl.cc View 1 2 1 chunk +10 lines, -2 lines 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_player_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_source_player_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_keys.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.h View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/pipeline_integration_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/api/private/ppb_content_decryptor_private.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/pp_macros.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/c/private/ppb_content_decryptor_private.h View 5 chunks +7 lines, -7 lines 0 comments Download
M ppapi/cpp/private/content_decryptor_private.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/private/content_decryptor_private.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 5 chunks +41 lines, -41 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppb_instance_proxy.cc View 1 2 3 4 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_private.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/thunk/ppb_content_decryptor_private_thunk.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M ppapi/thunk/ppb_instance_api.h View 1 2 3 4 5 6 1 chunk +6 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (0 generated)
xhwang
ddorwin@: Please review everything. dmichael@: Please review ppapi/*. https://codereview.chromium.org/179123009/diff/20001/ppapi/api/private/ppb_content_decryptor_private.idl File ppapi/api/private/ppb_content_decryptor_private.idl (right): https://codereview.chromium.org/179123009/diff/20001/ppapi/api/private/ppb_content_decryptor_private.idl#newcode15 ppapi/api/private/ppb_content_decryptor_private.idl:15: M35 ...
6 years, 9 months ago (2014-03-01 02:11:30 UTC) #1
ddorwin
lgtm % comments https://codereview.chromium.org/179123009/diff/20001/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc (right): https://codereview.chromium.org/179123009/diff/20001/content/renderer/media/android/webmediaplayer_android.cc#newcode1341 content/renderer/media/android/webmediaplayer_android.cc:1341: LOG(WARNING) << "system_code exceeds unsigned short ...
6 years, 9 months ago (2014-03-01 06:18:09 UTC) #2
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 18:58:38 UTC) #3
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 18:58:39 UTC) #4
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 18:58:40 UTC) #5
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 18:58:41 UTC) #6
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:00:22 UTC) #7
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:00:22 UTC) #8
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:03:55 UTC) #9
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:03:56 UTC) #10
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:03:57 UTC) #11
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:04:00 UTC) #12
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:05:30 UTC) #13
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:05:30 UTC) #14
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 19:05:32 UTC) #15
xhwang
Updated. Sorry for the noise. "git cl upload" is too darn flaky. https://codereview.chromium.org/179123009/diff/20001/content/renderer/media/android/webmediaplayer_android.cc File content/renderer/media/android/webmediaplayer_android.cc ...
6 years, 9 months ago (2014-03-03 19:06:35 UTC) #16
ddorwin
lgtm % coments https://codereview.chromium.org/179123009/diff/20001/ppapi/thunk/ppb_display_color_profile_private_thunk.cc File ppapi/thunk/ppb_display_color_profile_private_thunk.cc (right): https://codereview.chromium.org/179123009/diff/20001/ppapi/thunk/ppb_display_color_profile_private_thunk.cc#newcode52 ppapi/thunk/ppb_display_color_profile_private_thunk.cc:52: 4) << "PPB_DisplayColorProfile_Private::RegisterColorProfileChangeCallback()"; On 2014/03/03 19:06:36, ...
6 years, 9 months ago (2014-03-03 19:22:03 UTC) #17
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 22:19:00 UTC) #18
xhwang
comments addressed
6 years, 9 months ago (2014-03-03 22:19:03 UTC) #19
xhwang
https://codereview.chromium.org/179123009/diff/100001/ppapi/thunk/ppb_display_color_profile_private_thunk.cc File ppapi/thunk/ppb_display_color_profile_private_thunk.cc (right): https://codereview.chromium.org/179123009/diff/100001/ppapi/thunk/ppb_display_color_profile_private_thunk.cc#newcode6 ppapi/thunk/ppb_display_color_profile_private_thunk.cc:6: // modified Wed Feb 26 15:01:03 2014. On 2014/03/03 ...
6 years, 9 months ago (2014-03-03 23:29:11 UTC) #20
xhwang
dmichael: kindly ping! Please review ppapi/* files. Also, please see my question about whether I ...
6 years, 9 months ago (2014-03-03 23:30:21 UTC) #21
dmichael (off chromium)
ppapi lgtm
6 years, 9 months ago (2014-03-03 23:30:45 UTC) #22
dmichael (off chromium)
Yes, it's fine to bump the Chrome version. It tends to happen in whichever CL ...
6 years, 9 months ago (2014-03-03 23:31:56 UTC) #23
xhwang
On 2014/03/03 23:31:56, dmichael wrote: > Yes, it's fine to bump the Chrome version. It ...
6 years, 9 months ago (2014-03-03 23:34:52 UTC) #24
xhwang
TBRing dcheng@chromium.org on the tiny change in cdm_messages.h
6 years, 9 months ago (2014-03-03 23:35:52 UTC) #25
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 9 months ago (2014-03-03 23:36:05 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/179123009/120001
6 years, 9 months ago (2014-03-03 23:39:54 UTC) #27
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 00:10:26 UTC) #28
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53195
6 years, 9 months ago (2014-03-04 00:10:27 UTC) #29
xhwang
comments addressed
6 years, 9 months ago (2014-03-04 00:32:53 UTC) #30
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 9 months ago (2014-03-04 00:33:18 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/179123009/140001
6 years, 9 months ago (2014-03-04 00:34:44 UTC) #32
xhwang
On 2014/03/04 00:32:53, xhwang wrote: > comments addressed Updated tools/metrics/histograms/histograms.xml to suppress the presubmit warning ...
6 years, 9 months ago (2014-03-04 00:43:07 UTC) #33
commit-bot: I haz the power
6 years, 9 months ago (2014-03-04 06:11:13 UTC) #34
Message was sent while issue was closed. 
Change committed as 254693

Powered by Google App Engine
This is Rietveld 408576698