Add MD5 support when syncing debug files and option to just start gdbserver

Add MD5 support when syncing debug files and option to just start gdbserver

https://skia.googlecode.com/svn/trunk@9791

[borenet, 2013-06-27 12:46:42]

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_gdb_exe (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_gdb_exe:22: PORT=5039
Can we have these set by gdb_server and just read them here?  Seems fragile to
define them twice.

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_gdbserver (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_gdbserver:26: adb_pull_if_needed
/data/data/com.skia/lib/lib$APP_NAME.so $GDB_TMP_DIR/lib$APP_NAME.so
Optional: adb_pull_if_needed could use basename so that you don't have to state
it twice here.

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_setup.sh (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_setup.sh:191: adb_pull_if_needed() {
Nice!

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/ut...
File platform_tools/android/bin/utils/setup_adb.sh (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/ut...
platform_tools/android/bin/utils/setup_adb.sh:17: #echo "ADB is: $ADB"
Left in on purpose?

[djsollen, 2013-06-27 13:34:24]

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_gdb_exe (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_gdb_exe:22: PORT=5039
On 2013/06/27 12:46:42, borenet wrote:
> Can we have these set by gdb_server and just read them here?  Seems fragile to
> define them twice.

Yes it is fragile, but we aren't sourcing the gdbserver app which brings in
another set of problems. This seemed the lesser of two evils.

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_gdbserver (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_gdbserver:26: adb_pull_if_needed
/data/data/com.skia/lib/lib$APP_NAME.so $GDB_TMP_DIR/lib$APP_NAME.so
On 2013/06/27 12:46:42, borenet wrote:
> Optional: adb_pull_if_needed could use basename so that you don't have to
state
> it twice here.

Done.

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/ut...
File platform_tools/android/bin/utils/setup_adb.sh (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/ut...
platform_tools/android/bin/utils/setup_adb.sh:17: #echo "ADB is: $ADB"
On 2013/06/27 12:46:42, borenet wrote:
> Left in on purpose?

just in case I need to quickly debug

[borenet, 2013-06-27 13:40:14]

LGTM with optional suggestion.

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_gdb_exe (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_gdb_exe:22: PORT=5039
On 2013/06/27 13:34:24, djsollen wrote:
> On 2013/06/27 12:46:42, borenet wrote:
> > Can we have these set by gdb_server and just read them here?  Seems fragile
to
> > define them twice.
> 
> Yes it is fragile, but we aren't sourcing the gdbserver app which brings in
> another set of problems. This seemed the lesser of two evils.

I guess a solution might be to put these in some common file that gets sourced
by both scripts.  Optional.

[jvanverth1, 2013-06-27 15:09:04]

I'll defer to Eric's expertise on this one. Just a couple of comments:

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
File platform_tools/android/bin/android_gdb_exe (right):

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_gdb_exe:3: # android_gdb: Pushes gdbserver.
Connects and enters debugging environment.
rename to android_gdb_exe?

https://codereview.chromium.org/17910006/diff/1/platform_tools/android/bin/an...
platform_tools/android/bin/android_gdb_exe:22: PORT=5039
I was thinking a common file would be useful as well.

On 2013/06/27 13:40:14, borenet wrote:
> On 2013/06/27 13:34:24, djsollen wrote:
> > On 2013/06/27 12:46:42, borenet wrote:
> > > Can we have these set by gdb_server and just read them here?  Seems
fragile
> to
> > > define them twice.
> > 
> > Yes it is fragile, but we aren't sourcing the gdbserver app which brings in
> > another set of problems. This seemed the lesser of two evils.
> 
> I guess a solution might be to put these in some common file that gets sourced
> by both scripts.  Optional.