Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 17910003: Split memory-related routines out of base/process_util.h into base/process/memory.h. (Closed)

Created:
7 years, 6 months ago by Robert Sesek
Modified:
7 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Split memory-related routines out of base/process_util.h into base/process/memory.h. BUG=242290 R=brettw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=209172

Patch Set 1 #

Total comments: 4

Patch Set 2 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+583 lines, -1688 lines) Patch
M base/base.gyp View 1 2 chunks +5 lines, -3 lines 0 comments Download
M base/base.gypi View 4 chunks +12 lines, -0 lines 0 comments Download
A base/process/memory.h View 1 1 chunk +71 lines, -0 lines 0 comments Download
A + base/process/memory_linux.cc View 1 chunk +4 lines, -40 lines 0 comments Download
A + base/process/memory_mac.mm View 3 chunks +3 lines, -208 lines 0 comments Download
A base/process/memory_stubs.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A base/process/memory_unittest.cc View 1 chunk +379 lines, -0 lines 0 comments Download
A + base/process/memory_unittest_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + base/process/memory_unittest_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A base/process/memory_win.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M base/process_util.h View 6 chunks +1 line, -51 lines 0 comments Download
M base/process_util_freebsd.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M base/process_util_ios.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M base/process_util_linux.cc View 1 chunk +0 lines, -166 lines 0 comments Download
M base/process_util_mac.mm View 2 chunks +0 lines, -681 lines 0 comments Download
M base/process_util_openbsd.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M base/process_util_unittest.cc View 6 chunks +0 lines, -350 lines 0 comments Download
D base/process_util_unittest_mac.h View 1 chunk +0 lines, -32 lines 0 comments Download
D base/process_util_unittest_mac.mm View 1 chunk +0 lines, -59 lines 0 comments Download
M base/process_util_win.cc View 3 chunks +0 lines, -67 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
7 years, 6 months ago (2013-06-26 19:55:53 UTC) #1
brettw
lgtm https://codereview.chromium.org/17910003/diff/1/base/base.gyp File base/base.gyp (right): https://codereview.chromium.org/17910003/diff/1/base/base.gyp#newcode689 base/base.gyp:689: ['exclude', '^process_util_unittest.cc'], You probably want to escape this ...
7 years, 5 months ago (2013-06-27 21:42:50 UTC) #2
Robert Sesek
https://codereview.chromium.org/17910003/diff/1/base/base.gyp File base/base.gyp (right): https://codereview.chromium.org/17910003/diff/1/base/base.gyp#newcode689 base/base.gyp:689: ['exclude', '^process_util_unittest.cc'], On 2013/06/27 21:42:51, brettw wrote: > You ...
7 years, 5 months ago (2013-06-28 16:45:21 UTC) #3
Robert Sesek
7 years, 5 months ago (2013-06-28 17:40:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r209172.

Powered by Google App Engine
This is Rietveld 408576698