content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc - Issue 1790753002: Expose GLES2Interface to blink, and delete isContextLost() from WGC3D.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 1790753002: Expose GLES2Interface to blink, and delete isContextLost() from WGC3D. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wgc3d: deps-for-tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/renderer/webgraphicscontext3d_provider_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

index 3a1745fb48bbe1d469665a032868b568ff0914ff..028e874dc445547b67d29da070651385aed7c9f5 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

@@ -249,7 +249,7 @@ bool WebGraphicsContext3DCommandBufferImpl::CreateContext() {

gles2_helper_.get(), gles2_share_group.get(), transfer_buffer_.get(),

bind_generates_resources, lose_context_when_out_of_memory_,

support_client_side_arrays, command_buffer_.get()));

- setGLInterface(real_gl_.get());

+ SetGLInterface(real_gl_.get());

if (!real_gl_->Initialize(

mem_limits_.start_transfer_buffer_size,

@@ -266,7 +266,7 @@ bool WebGraphicsContext3DCommandBufferImpl::CreateContext() {

if (base::CommandLine::ForCurrentProcess()->HasSwitch(

switches::kEnableGpuClientTracing)) {

trace_gl_.reset(new gpu::gles2::GLES2TraceImplementation(GetGLInterface()));

- setGLInterface(trace_gl_.get());

+ SetGLInterface(trace_gl_.get());

}

return true;

}

@@ -296,7 +296,7 @@ void WebGraphicsContext3DCommandBufferImpl::Destroy() {

// issued on this context might not be visible to other contexts in the

// share group.

gl->Flush();

- setGLInterface(NULL);

+ SetGLInterface(nullptr);

}

trace_gl_.reset();

@@ -306,7 +306,7 @@ void WebGraphicsContext3DCommandBufferImpl::Destroy() {

real_gl_.reset();

command_buffer_.reset();

- host_ = NULL;

+ host_ = nullptr;

}

gpu::ContextSupport*