Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 179068: Extension Doc Changes (no building or testable changes): minor changes for tab & windows doc (Closed)

Created:
11 years, 3 months ago by rafaelw
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Extension Doc Changes (no building or testable changes): minor changes for tab & windows doc Tabs, Windows, Bookmarks, Themes doc content changes. Fix internal anchor problem (not hiding/showing for rendered docs). Only render dynamically for file: scheme. Fix <pre> issues in rendered docs (now no longer all one line). Alphabetize methods, events & types. Use h* ids for anchor names if found. BUG=20803 TBR=aa

Patch Set 1 #

Total comments: 2

Patch Set 2 : bunch of bug fixes #

Patch Set 3 : touch grd. rendered docs #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15634 lines, -138 lines) Patch
M chrome/common/common_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/docs/api_index.html View 1 chunk +381 lines, -1 line 2 comments Download
M chrome/common/extensions/docs/api_other.html View 1 chunk +409 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/background_pages.html View 1 chunk +429 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/build/build.py View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/docs/build/generator.html View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/content_scripts.html View 1 chunk +586 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/devguide.html View 1 chunk +364 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/devtools.html View 1 chunk +389 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/events.html View 2 chunks +386 lines, -20 lines 0 comments Download
M chrome/common/extensions/docs/extension.html View 1 chunk +1548 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/getstarted.html View 1 chunk +570 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/index.html View 1 chunk +442 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 2 chunks +16 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/js/bootstrap.js View 2 1 chunk +22 lines, -24 lines 0 comments Download
M chrome/common/extensions/docs/manifest.html View 1 chunk +502 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/match_patterns.html View 2 chunks +529 lines, -20 lines 0 comments Download
M chrome/common/extensions/docs/npapi.html View 1 chunk +420 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/overview.html View 1 chunk +762 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/packaging.html View 1 chunk +498 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/pageActions.html View 1 chunk +839 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/static/bookmarks.html View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/static/themes.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/tabs.html View 1 chunk +3848 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/template/api_template.html View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/docs/test.html View 1 chunk +549 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/themes.html View 2 chunks +459 lines, -20 lines 0 comments Download
M chrome/common/extensions/docs/toolstrip.html View 1 chunk +815 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/tut_debugging.html View 1 chunk +486 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/tutorials.html View 1 chunk +363 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Aaron Boodman
lgtm http://codereview.chromium.org/179068/diff/1/2 File chrome/common/extensions/api/extension_api.json (right): http://codereview.chromium.org/179068/diff/1/2#newcode206 Line 206: "url": {"type": "string", "optional": true, "description": "The ...
11 years, 3 months ago (2009-09-01 18:28:44 UTC) #1
Kathy Walrath
Looks terrific. Thanks for doing this! -k-
11 years, 3 months ago (2009-09-02 04:42:08 UTC) #2
Aaron Boodman
11 years, 3 months ago (2009-09-02 08:12:24 UTC) #3
http://codereview.chromium.org/179068/diff/3010/5
File chrome/common/extensions/docs/api_index.html (right):

http://codereview.chromium.org/179068/diff/3010/5#newcode379
Line 379: </div> <!-- /container -->
Hooray for \n and \t!

http://codereview.chromium.org/179068/diff/3010/5#newcode381
Line 381: #EOF
Err, is this #EOF actually in the file? Won't that render?

Powered by Google App Engine
This is Rietveld 408576698