Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1790633004: [WebView] Add an isolate file to run the WebView Layout tests. (Closed)

Created:
4 years, 9 months ago by mikecase (-- gone --)
Modified:
4 years, 9 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Add an isolate file to run the WebView Layout tests. Adding an isolate file similiar to what exists for the AndroidWebViewTest.apk to run the instrumentation test through the isolate file. BUG= Committed: https://crrev.com/a136dc99c3e5f7e02263aa86085769a569a01a47 Cr-Commit-Position: refs/heads/master@{#381522}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Total comments: 1

Patch Set 4 : Remove a bunch of unneccesary arguments to the test runner scripts. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -10 lines) Patch
M android_webview/android_webview_test_apk_run.isolate View 1 2 3 1 chunk +3 lines, -4 lines 0 comments Download
A android_webview/system_webview_shell_layout_test_apk_run.isolate View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
M android_webview/tools/BUILD.gn View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/android/chrome_public_test_apk.isolate View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/chrome_sync_shell_test_apk.isolate View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/content_shell_test_apk_run.isolate View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (6 generated)
mikecase (-- gone --)
Thought I should add this because there is something similar for the AndroidWebViewTest.apk. https://code.google.com/p/chromium/codesearch#chromium/src/android_webview/android_webview_test_apk_run.isolate We ...
4 years, 9 months ago (2016-03-12 01:24:51 UTC) #2
mikecase (-- gone --)
https://codereview.chromium.org/1790633004/diff/20001/android_webview/system_webview_shell_layout_test_apk_run.isolate File android_webview/system_webview_shell_layout_test_apk_run.isolate (right): https://codereview.chromium.org/1790633004/diff/20001/android_webview/system_webview_shell_layout_test_apk_run.isolate#newcode21 android_webview/system_webview_shell_layout_test_apk_run.isolate:21: '<(PRODUCT_DIR)/SystemWebView.apk', fixed missing apk/
4 years, 9 months ago (2016-03-12 01:25:49 UTC) #3
jbudorick
https://codereview.chromium.org/1790633004/diff/40001/android_webview/system_webview_shell_layout_test_apk_run.isolate File android_webview/system_webview_shell_layout_test_apk_run.isolate (right): https://codereview.chromium.org/1790633004/diff/40001/android_webview/system_webview_shell_layout_test_apk_run.isolate#newcode13 android_webview/system_webview_shell_layout_test_apk_run.isolate:13: '--additional-apk', '<(PRODUCT_DIR)/apks/SystemWebView.apk', neither this nor the following line should ...
4 years, 9 months ago (2016-03-12 01:27:29 UTC) #4
mikecase (-- gone --)
Removed the --additional-apk arg by adding the additional_apk var in GN for those targets. Removed ...
4 years, 9 months ago (2016-03-12 02:23:15 UTC) #5
mikecase (-- gone --)
friendly ping
4 years, 9 months ago (2016-03-15 17:49:10 UTC) #6
jbudorick
lgtm
4 years, 9 months ago (2016-03-15 19:15:14 UTC) #7
mikecase (-- gone --)
+ sgurun@chromium.org for review of android_webview/ + yfriedman@chromium.org for review of chrome/android/ + maruel@chromium.org for ...
4 years, 9 months ago (2016-03-15 20:26:30 UTC) #9
M-A Ruel
rs lgtm
4 years, 9 months ago (2016-03-15 20:34:40 UTC) #10
Yaron
lgtm
4 years, 9 months ago (2016-03-16 02:21:02 UTC) #11
sgurun-gerrit only
On 2016/03/16 02:21:02, Yaron wrote: > lgtm lgtm
4 years, 9 months ago (2016-03-16 15:55:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790633004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790633004/60001
4 years, 9 months ago (2016-03-16 16:23:52 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/183340)
4 years, 9 months ago (2016-03-16 18:12:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790633004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790633004/60001
4 years, 9 months ago (2016-03-16 18:16:07 UTC) #18
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-16 20:42:39 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:44:37 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a136dc99c3e5f7e02263aa86085769a569a01a47
Cr-Commit-Position: refs/heads/master@{#381522}

Powered by Google App Engine
This is Rietveld 408576698