Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
17906002:
Fix mess in ImageDecoder::setRGB* methods after r153004 (Closed)
|
Created:
7 years, 6 months ago by kbalazs_ Modified:
7 years, 5 months ago CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, jeez Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Visibility:
Public. |
DescriptionFix mess in ImageDecoder::setRGB* methods after r153004
I was acidentally changed the order of alpha tests (0, 255).
Also my asserts are adding more noise than value so remove them.
R=noel@chromium.org
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153264
Patch Set 1 #
Messages
Total messages: 17 (0 generated)
FYI: I have a patch out to make the JPEG decoder use buffer.setRGBARaw() https://codereview.chromium.org/17815002 and I'll need to adjust it based on this change.
Context: Follow-up to https://codereview.chromium.org/17448010 post-landing.
LGTM
On 2013/06/27 14:32:26, Noel Gordon (Google) wrote: > LGTM Unfortunately we have a regression with the original patch, so I think we should revert it for now: http://code.google.com/p/chromium/issues/detail?id=254462 Strange that it regressed gif decoding, maybe an inlining issue.
On 2013/06/28 12:14:46, kbalazs wrote: > On 2013/06/27 14:32:26, Noel Gordon (Google) wrote: > > LGTM > > Unfortunately we have a regression with the original patch, so I think we should > revert it for now: http://code.google.com/p/chromium/issues/detail?id=254462 > Strange that it regressed gif decoding, maybe an inlining issue. ... but I think this patch should fix it, so I'm going to land and watch the results.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/17906002/1
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...
Did your change make it into a chrome release branch (the cut for dev)? You'd better go check. In general, I would revert the original change and try again.
On 2013/06/28 13:16:39, Noel Gordon (Google) wrote: > Did your change make it into a chrome release branch (the cut for dev)? You'd > better go check. > > In general, I would revert the original change and try again. Could you help me in that? I'm not a committer so I can't revert. Change rev was 153004. Thanks!
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/17906002/1
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/b.kelemen@sisa.samsung.com/17906002/1
Message was sent while issue was closed.
Change committed as 153264
Message was sent while issue was closed.
Many thanks for helping me out with this. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
