Move the VM's typed_data implementation to runtime/lib.

Move the VM's typed_data implementation to runtime/lib.

This removes the additional indirection to the VM's implementation
for all the factory constructors.

Additionally, it removes one class per typed data list type, thus reducing
snapshot and generated code size.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/f3de2377ab4a5a021bcdbc288abb41dd2901bc17

[Florian Schneider, 2016-03-11 16:43:03]

fschneider@google.com changed reviewers:
+ asiva@google.com, iposva@google.com

[Florian Schneider, 2016-03-11 16:46:33]

Description was changed from

==========
Move the VM's typed_data implementation to runtime/lib.

This removes the additional indirection to the VM's implementation
for all the factory constructors.

Additionally, it one class per typed data list type, thus reducing
snapshot and generated code size.

BUG=
==========

to

==========
Move the VM's typed_data implementation to runtime/lib.

This removes the additional indirection to the VM's implementation
for all the factory constructors.

Additionally, it removes one class per typed data list type, thus reducing
snapshot and generated code size.

BUG=
==========

[siva, 2016-03-14 17:37:32]

lgtm

[Florian Schneider, 2016-03-21 12:39:53]

Description was changed from

==========
Move the VM's typed_data implementation to runtime/lib.

This removes the additional indirection to the VM's implementation
for all the factory constructors.

Additionally, it removes one class per typed data list type, thus reducing
snapshot and generated code size.

BUG=
==========

to

==========
Move the VM's typed_data implementation to runtime/lib.

This removes the additional indirection to the VM's implementation
for all the factory constructors.

Additionally, it removes one class per typed data list type, thus reducing
snapshot and generated code size.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f3de2377ab4a5a021bcdbc288abb41dd2901bc17
==========

[Florian Schneider, 2016-03-21 12:39:55]

Committed patchset #1 (id:1) manually as
f3de2377ab4a5a021bcdbc288abb41dd2901bc17 (presubmit successful).

[zra, 2016-03-23 17:23:48]

zra@google.com changed reviewers:
+ zra@google.com

[zra, 2016-03-23 17:23:49]

DBC

https://codereview.chromium.org/1790593002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (right):

https://codereview.chromium.org/1790593002/diff/1/runtime/vm/vm.gypi#newcode975
runtime/vm/vm.gypi:975: '../lib/typed_data_sources.gypi',
Can this be changed back? This change breaks the convention that patch sources
come from ../lib and the shared sources come from ../sdk/lib, which we were
relying on for the GN build here:
https://github.com/dart-lang/sdk/blob/master/runtime/vm/BUILD.gn#L109. This is
making the roll into Mojo difficult, and will probably make the roll into
Flutter difficult, as well.

[zra, 2016-03-23 17:25:26]

+johnmccutchan FYI

[zra, 2016-03-23 20:26:30]

On 2016/03/23 17:23:49, zra wrote:
> DBC
> 
> https://codereview.chromium.org/1790593002/diff/1/runtime/vm/vm.gypi
> File runtime/vm/vm.gypi (right):
> 
>
https://codereview.chromium.org/1790593002/diff/1/runtime/vm/vm.gypi#newcode975
> runtime/vm/vm.gypi:975: '../lib/typed_data_sources.gypi',
> Can this be changed back? This change breaks the convention that patch sources
> come from ../lib and the shared sources come from ../sdk/lib, which we were
> relying on for the GN build here:
> https://github.com/dart-lang/sdk/blob/master/runtime/vm/BUILD.gn#L109. This is
> making the roll into Mojo difficult, and will probably make the roll into
> Flutter difficult, as well.

I worked around this with https://codereview.chromium.org/1825213004/, but it
would be nice to avoid complicating the macro further.