Fix two issues with the plugin installer....

webkit/default_plugin/install_dialog.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/default_plugin/install_dialog.h"
 
+#include "base/hash_tables.h"
+#include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "grit/webkit_strings.h"
 #include "webkit/default_plugin/plugin_impl.h"
 #include "webkit/glue/webkit_glue.h"
 
-bool PluginInstallDialog::Initialize(PluginInstallerImpl* plugin_impl,
-                                     const std::wstring& plugin_name) {
-  if (!plugin_impl) {
-    NOTREACHED();
-    return false;
+typedef base::hash_map<const std::wstring, PluginInstallDialog*> DialogMap;
+base::LazyInstance<DialogMap> s_dialogs(base::LINKER_INITIALIZED);
+
+PluginInstallDialog* PluginInstallDialog::AddInstaller(
+    PluginInstallerImpl* plugin_impl, const std::wstring& plugin_name) {
+  PluginInstallDialog* dialog;
+  if (s_dialogs.Get().count(plugin_name)) {
+    dialog = s_dialogs.Get()[plugin_name];
+  } else {
+    dialog = new PluginInstallDialog(plugin_name);
   }
 
-  plugin_impl_ = plugin_impl;
-  plugin_name_ = plugin_name;
-  return true;
+  dialog->installers_.push_back(plugin_impl);
+  return dialog;
+}
+
+PluginInstallDialog::PluginInstallDialog(const std::wstring& plugin_name)
+    : plugin_name_(plugin_name) {
+  s_dialogs.Get()[plugin_name] = this;
+}
+
+PluginInstallDialog::~PluginInstallDialog() {
+  s_dialogs.Get().erase(plugin_name_);
+  if (IsWindow())
+    DestroyWindow();
+}
+
+void PluginInstallDialog::RemoveInstaller(PluginInstallerImpl* installer) {
+  for (size_t i = 0; i < installers_.size(); ++i) {
+    if (installers_[i] == installer) {
+      installers_.erase(installers_.begin() + i);
+      if (installers_.empty())
+        delete this;
+      return;
+    }
+  }
+  NOTREACHED();
+}
+
+void PluginInstallDialog::ShowInstallDialog() {
+  if (IsWindow())
+    return;
+
+  Create(NULL, NULL);
+  ShowWindow(SW_SHOW);
 }
 
 HWND PluginInstallDialog::Create(HWND parent_window, LPARAM init_param) {
   // Most of the code here is based on CDialogImpl<T>::Create.
   DCHECK(m_hWnd == NULL);
 
   // Allocate the thunk structure here, where we can fail
   // gracefully.
   BOOL thunk_inited = m_thunk.Init(NULL, NULL);
   if (thunk_inited == FALSE) {
@@ skipping 26 matching lines @@
   _DialogSplitHelper::DLGTEMPLATEEX* dialog_template_struct =
       reinterpret_cast<_DialogSplitHelper::DLGTEMPLATEEX *>(
           ::LockResource(dialog_template));
   DCHECK(dialog_template_struct != NULL);
 
   unsigned long dialog_template_size =
       SizeofResource(instance_handle, dialog_resource);
 
   HGLOBAL rtl_layout_dialog_template = NULL;
 
-  if (IsRTLLayout()) {
+  if (PluginInstallerImpl::IsRTLLayout()) {
     rtl_layout_dialog_template = GlobalAlloc(GPTR, dialog_template_size);
     DCHECK(rtl_layout_dialog_template != NULL);
 
     _DialogSplitHelper::DLGTEMPLATEEX* rtl_layout_dialog_template_struct =
         reinterpret_cast<_DialogSplitHelper::DLGTEMPLATEEX*>(
             ::GlobalLock(rtl_layout_dialog_template));
     DCHECK(rtl_layout_dialog_template_struct != NULL);
 
     memcpy(rtl_layout_dialog_template_struct, dialog_template_struct,
            dialog_template_size);
@@ skipping 50 matching lines @@
           plugin_name_);
   AdjustTextDirectionality(&plugin_user_action_msg);
   SetDlgItemText(IDC_PLUGIN_INSTALL_CONFIRMATION_LABEL,
                  plugin_user_action_msg.c_str());
   return 0;
 }
 
 
 LRESULT PluginInstallDialog::OnGetPlugin(WORD notify_code, WORD id,
                                          HWND wnd_ctl, BOOL &handled) {
-  if (!plugin_impl_) {
-    NOTREACHED();
-    return 0;
-  }
+  DestroyWindow();
+  if (!installers_.empty())
+    installers_[0]->DownloadPlugin();
 
-  DestroyWindow();
-  plugin_impl_->DownloadPlugin();
   return 0;
 }
 
 LRESULT PluginInstallDialog::OnCancel(WORD notify_code, WORD id, HWND wnd_ctl,
                                       BOOL &handled) {
   DestroyWindow();
-  plugin_impl_->DownloadCancelled();
+  if (!installers_.empty())
+    installers_[0]->DownloadCancelled();
   return 0;
 }
 
-
-bool PluginInstallDialog::IsRTLLayout() const {
-  return plugin_impl_ ? plugin_impl_->IsRTLLayout() : false;
-}
-
 // TODO(idana) bug# 1246452: use the library l10n_util once it is moved from
 // the Chrome module into the Base module. For now, we simply copy/paste the
 // same code.
 void PluginInstallDialog::AdjustTextDirectionality(std::wstring* text) const {
-  if (IsRTLLayout()) {
+  if (PluginInstallerImpl::IsRTLLayout()) {
     // Inserting an RLE (Right-To-Left Embedding) mark as the first character.
     text->insert(0, L"\x202B");
 
     // Inserting a PDF (Pop Directional Formatting) mark as the last character.
     text->append(L"\x202C");
   }
 }