Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 1790493003: crashpad win: Ensure database dir exists on first run (Closed)

Created:
4 years, 9 months ago by scottmg
Modified:
4 years, 9 months ago
Reviewers:
Nico, Will Harris
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

crashpad win: Ensure database dir exists on first run Crashpad will only create one level of directory for its database storage. On Windows, the target is %LOCALAPPDATA%\Google\Chrome\User Data\Crashpad. However, on first run when Crashpad is initialized, "User Data" will not yet have been created. We don't want to move Crashpad initialization later in startup, so we instead create the directory if it does not exist. Note that this is calling file_util::CreateDirectory(), rather than CreateDirectoryW() which means the full parent tree will be created, not just the last entry in the path. R=thakis@chromium.org,wfh@chromium.org TEST=remove local user data dir, install chrome, confirm that chrome --process-type=crashpad-handler exists on first run BUG=591504 Review URL: https://codereview.chromium.org/1774573002 Cr-Commit-Position: refs/heads/master@{#379676} (cherry picked from commit 92905ef36a30be9be9041d8ee07ccd6e7ca45d64) Committed: https://chromium.googlesource.com/chromium/src/+/4a5c529d37e17c3ea7def8aa7de2507a5548d84d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/common/chrome_paths_win.cc View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
scottmg
4 years, 9 months ago (2016-03-11 18:44:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a5c529d37e17c3ea7def8aa7de2507a5548d84d.

Powered by Google App Engine
This is Rietveld 408576698