Chromium Code Reviews
DescriptionRevert of Enable zoom through gamedpad trigger joystick (patchset #11 id:200001 of https://codereview.chromium.org/1288243004/ )
Reason for revert:
FindBugs issues on ContentViewZoomingTest.java
Builder: clang-clankium-tot-builder
FindBugs reported the following issues:
SIC_INNER_SHOULD_BE_STATIC: Should be a static inner class
In class org.chromium.content.browser.ContentViewZoomingTest$TestAnimationIntervalProvider
At ContentViewZoomingTest.java:[lines 29-34]
Original issue's description:
> Enable zoom through gamedpad trigger joystick
>
> This change allows page zoomin/out using trigger joysticks.
> Page zoomin and zoomout can be achieved using left and right
> trigger joysticks respectively.
>
> BUG=454355
>
> Committed: https://crrev.com/84583b7d70d5bf5adac05346811b5422033c4e86
> Cr-Commit-Position: refs/heads/master@{#380572}
TBR=aelias@chromium.org,tdresser@chromium.org,yfriedman@chromium.org,sshelke@nvidia.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454355
Committed: https://crrev.com/52643c06c9af36fdb16113e104bd6771324fcd61
Cr-Commit-Position: refs/heads/master@{#380602}
Patch Set 1 #
Messages
Total messages: 11 (4 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||