Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1790493002: Revert of Enable zoom through gamedpad trigger joystick (Closed)

Created:
4 years, 9 months ago by May
Modified:
4 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable zoom through gamedpad trigger joystick (patchset #11 id:200001 of https://codereview.chromium.org/1288243004/ ) Reason for revert: FindBugs issues on ContentViewZoomingTest.java Builder: clang-clankium-tot-builder FindBugs reported the following issues: SIC_INNER_SHOULD_BE_STATIC: Should be a static inner class In class org.chromium.content.browser.ContentViewZoomingTest$TestAnimationIntervalProvider At ContentViewZoomingTest.java:[lines 29-34] Original issue's description: > Enable zoom through gamedpad trigger joystick > > This change allows page zoomin/out using trigger joysticks. > Page zoomin and zoomout can be achieved using left and right > trigger joysticks respectively. > > BUG=454355 > > Committed: https://crrev.com/84583b7d70d5bf5adac05346811b5422033c4e86 > Cr-Commit-Position: refs/heads/master@{#380572} TBR=aelias@chromium.org,tdresser@chromium.org,yfriedman@chromium.org,sshelke@nvidia.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454355 Committed: https://crrev.com/52643c06c9af36fdb16113e104bd6771324fcd61 Cr-Commit-Position: refs/heads/master@{#380602}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
May
Created Revert of Enable zoom through gamedpad trigger joystick
4 years, 9 months ago (2016-03-11 11:45:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790493002/1
4 years, 9 months ago (2016-03-11 11:46:28 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 9 months ago (2016-03-11 11:46:29 UTC) #4
dgn
lgtm
4 years, 9 months ago (2016-03-11 11:50:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790493002/1
4 years, 9 months ago (2016-03-11 11:50:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 11:51:22 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 11:52:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52643c06c9af36fdb16113e104bd6771324fcd61
Cr-Commit-Position: refs/heads/master@{#380602}

Powered by Google App Engine
This is Rietveld 408576698