Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 1790463004: [MD settings] change side nav icons - remove cloud print item (Closed)

Created:
4 years, 9 months ago by dschuyler
Modified:
4 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] change side nav icons - remove cloud print item The brightness-1 (dot) icons are replaced with better icons for the settings side nav. The Google Cloud Print menu item was removed because that's not in the first MD settings pass. BUG=593989 Committed: https://crrev.com/4c2c0b6d78278126617f352711e22ff0baa59277 Cr-Commit-Position: refs/heads/master@{#380863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 3 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dschuyler
4 years, 9 months ago (2016-03-12 01:26:08 UTC) #2
dpapad
lgtm
4 years, 9 months ago (2016-03-12 01:33:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1790463004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1790463004/1
4 years, 9 months ago (2016-03-12 02:24:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-12 04:57:29 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-12 04:59:10 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c2c0b6d78278126617f352711e22ff0baa59277
Cr-Commit-Position: refs/heads/master@{#380863}

Powered by Google App Engine
This is Rietveld 408576698