Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1790433009: Try to get clang/win tot bots going again after VS2015 update. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
hans, brucedawson
CC:
chromium-reviews, yunlian, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to get clang/win tot bots going again after VS2015 update. We wanted to always get VS2013 from gyp (since that's most-tested for LLVM builds), but apparently compiler and library versions get out of sync if we don't request the default VS version. So do that. BUG=none R=brucedawson@chromium.org Committed: https://crrev.com/4f829bb6497c48efe1074487c4fea7c7e7e760e0 Cr-Commit-Position: refs/heads/master@{#380758}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
brucedawson
Yep, that seems right. lgtm. The nice thing about that change is that it continues ...
4 years, 9 months ago (2016-03-11 22:30:23 UTC) #3
Nico
hans fyi
4 years, 9 months ago (2016-03-11 22:31:56 UTC) #5
Nico
Committed patchset #1 (id:1) to pending queue manually as 7252bee0f6509e2f14970ecfba9e233f733886a6 (presubmit successful).
4 years, 9 months ago (2016-03-11 22:32:19 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 22:33:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f829bb6497c48efe1074487c4fea7c7e7e760e0
Cr-Commit-Position: refs/heads/master@{#380758}

Powered by Google App Engine
This is Rietveld 408576698