Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 179043005: [GCM] Remove the requirement for manifest key (Closed)

Created:
6 years, 9 months ago by jianli
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

[GCM] Remove the requirement for manifest key We also remove cert from the registration request. BUG=345413 TEST=tests updated R=fgorski@chromium.org, tim@chromium.org, zea@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255136

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove cert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -105 lines) Patch
M chrome/browser/extensions/api/gcm/gcm_api.cc View 1 5 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_apitest.cc View 1 2 chunks +0 lines, -10 lines 0 comments Download
chrome/browser/invalidation/gcm_network_channel_delegate_impl.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_profile_service.h View 1 4 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/services/gcm/fake_gcm_profile_service.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download
chrome/browser/services/gcm/gcm_client_mock.h View 1 1 chunk +0 lines, -1 line 0 comments Download
chrome/browser/services/gcm/gcm_client_mock.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service.cc View 1 5 chunks +7 lines, -13 lines 0 comments Download
M chrome/browser/services/gcm/gcm_profile_service_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/gcm/functions/incognito/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/gcm/functions/register/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/register_without_key/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/gcm/functions/register_without_key/register.js View 1 chunk +0 lines, -15 lines 0 comments Download
google_apis/gcm/engine/registration_request.h View 1 1 chunk +0 lines, -1 line 0 comments Download
google_apis/gcm/engine/registration_request.cc View 1 4 chunks +0 lines, -5 lines 0 comments Download
google_apis/gcm/engine/registration_request_unittest.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M google_apis/gcm/gcm_client.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
google_apis/gcm/gcm_client_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
google_apis/gcm/gcm_client_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
google_apis/gcm/gcm_client_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
jianli
6 years, 9 months ago (2014-02-27 19:59:13 UTC) #1
Nicolas Zea
gcm lgtm
6 years, 9 months ago (2014-02-27 20:16:29 UTC) #2
fgorski
https://codereview.chromium.org/179043005/diff/1/chrome/browser/extensions/api/gcm/gcm_api.cc File chrome/browser/extensions/api/gcm/gcm_api.cc (right): https://codereview.chromium.org/179043005/diff/1/chrome/browser/extensions/api/gcm/gcm_api.cc#newcode124 chrome/browser/extensions/api/gcm/gcm_api.cc:124: SHA1HashHexString(GetExtension()->id()), please investigate if we need to pass a ...
6 years, 9 months ago (2014-02-27 23:39:30 UTC) #3
jianli
https://codereview.chromium.org/179043005/diff/1/chrome/browser/extensions/api/gcm/gcm_api.cc File chrome/browser/extensions/api/gcm/gcm_api.cc (right): https://codereview.chromium.org/179043005/diff/1/chrome/browser/extensions/api/gcm/gcm_api.cc#newcode124 chrome/browser/extensions/api/gcm/gcm_api.cc:124: SHA1HashHexString(GetExtension()->id()), On 2014/02/27 23:39:30, Filip Gorski wrote: > please ...
6 years, 9 months ago (2014-02-28 19:53:40 UTC) #4
fgorski
lgtm
6 years, 9 months ago (2014-03-01 22:29:58 UTC) #5
jianli
The CQ bit was checked by jianli@chromium.org
6 years, 9 months ago (2014-03-03 17:58:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/179043005/60001
6 years, 9 months ago (2014-03-03 17:59:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/179043005/60001
6 years, 9 months ago (2014-03-03 18:30:52 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 18:51:43 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=53097
6 years, 9 months ago (2014-03-03 18:51:44 UTC) #10
jianli
Tim, could you please approve the changes to invalidation directory?
6 years, 9 months ago (2014-03-03 21:16:48 UTC) #11
tim (not reviewing)
lgtm, +Pavel fyi / for supervision
6 years, 9 months ago (2014-03-05 18:38:22 UTC) #12
jianli
6 years, 9 months ago (2014-03-05 20:21:07 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 manually as r255136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698