Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/cocoa/delayedmenu_button_unittest.mm

Issue 179043: (Mac) Added unit tests for ClickHoldButtonCell and DelayedMenuButton. (Closed)
Patch Set: Read gtest docs; using constructors instead of SetUp() is okay. Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/delayedmenu_button.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/delayedmenu_button_unittest.mm
diff --git a/chrome/browser/cocoa/delayedmenu_button_unittest.mm b/chrome/browser/cocoa/delayedmenu_button_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..b04cb27c7dedf62805218127477b5aaf863579c2
--- /dev/null
+++ b/chrome/browser/cocoa/delayedmenu_button_unittest.mm
@@ -0,0 +1,71 @@
+// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import <Cocoa/Cocoa.h>
+
+#include "base/scoped_nsobject.h"
+#import "chrome/browser/cocoa/clickhold_button_cell.h"
+#import "chrome/browser/cocoa/cocoa_test_helper.h"
+#import "chrome/browser/cocoa/delayedmenu_button.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "testing/platform_test.h"
+
+namespace {
+
+class DelayedMenuButtonTest : public PlatformTest {
+ public:
+ DelayedMenuButtonTest() {
+ NSRect frame = NSMakeRect(0, 0, 50, 30);
+ button_.reset([[DelayedMenuButton alloc] initWithFrame:frame]);
+ scoped_nsobject<ClickHoldButtonCell> cell(
+ [[ClickHoldButtonCell alloc] initTextCell:@"Testing"]);
+ [button_ setCell:cell.get()];
+ [cocoa_helper_.contentView() addSubview:button_.get()];
+ }
+
+ scoped_nsobject<DelayedMenuButton> button_;
+ CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc.
+};
+
+// Test adding/removing from the view hierarchy, mostly to ensure nothing leaks
+// or crashes.
+TEST_F(DelayedMenuButtonTest, AddRemove) {
+ EXPECT_EQ(cocoa_helper_.contentView(), [button_ superview]);
+ [button_.get() removeFromSuperview];
+ EXPECT_FALSE([button_ superview]);
+}
+
+// Test drawing, mostly to ensure nothing leaks or crashes.
+TEST_F(DelayedMenuButtonTest, Display) {
+ [button_ display];
+}
+
+// Test assigning and enabling a menu, again mostly to ensure nothing leaks or
+// crashes.
+TEST_F(DelayedMenuButtonTest, MenuAssign) {
+ scoped_nsobject<NSMenu> menu([[NSMenu alloc] initWithTitle:@""]);
+ ASSERT_TRUE(menu.get());
+
+ [menu insertItemWithTitle:@"" action:nil keyEquivalent:@"" atIndex:0];
+ [menu insertItemWithTitle:@"foo" action:nil keyEquivalent:@"" atIndex:1];
+ [menu insertItemWithTitle:@"bar" action:nil keyEquivalent:@"" atIndex:2];
+ [menu insertItemWithTitle:@"baz" action:nil keyEquivalent:@"" atIndex:3];
+
+ [button_ setMenu:menu];
+ EXPECT_TRUE([button_ menu]);
+
+ [button_ setMenuEnabled:YES];
+ EXPECT_TRUE([button_ menuEnabled]);
+
+ // TODO(viettrungluu): Display the menu. (Calling DelayedMenuButton's private
+ // |-menuAction:| method displays it fine, but the problem is getting rid of
+ // the menu. We can catch the |NSMenuDidBeginTrackingNotification| from |menu|
+ // fine, but then |-cancelTracking| doesn't dismiss it. I don't know why.)
+}
+
+// TODO(viettrungluu): Test the two actions of the button (the normal one and
+// displaying the menu, also making sure the latter drags correctly)? It would
+// require "emulating" a mouse....
+
+} // namespace
« no previous file with comments | « chrome/browser/cocoa/delayedmenu_button.mm ('k') | chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698