Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1475)

Unified Diff: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc

Issue 17904008: Fixing gpu_ipc_browsertests.cc (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: mac fix Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/content_browser_test.cc ('k') | webkit/common/gpu/webkit_gpu.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
diff --git a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
index 203ffac8301e2ff92fc87a4a4805019c8656e52b..c193946c6d94c319122d278af927251f633ba3aa 100644
--- a/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
+++ b/webkit/common/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc
@@ -1237,7 +1237,10 @@ void WebGraphicsContext3DInProcessCommandBufferImpl::signalSyncPoint(
// Take ownership of the callback.
context_->SignalSyncPoint(
sync_point, base::Bind(&OnSignalSyncPoint, base::Owned(callback)));
- // Stick something in the command buffer.
+ // Make sure we have something to flush, or shallowFlushCHROMIUM()
+ // doesn't do anything.
+ gl_->helper()->Noop(1);
+ // This fill force PumpCommands() to run which is what triggers the signal.
shallowFlushCHROMIUM();
}
« no previous file with comments | « content/test/content_browser_test.cc ('k') | webkit/common/gpu/webkit_gpu.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698