Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issue 17904007: Do not allow invocation of ArrayBuffer and array buffer views' constructors as functions. (Closed)

Created:
7 years, 6 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 6 months ago
Reviewers:
rossberg
CC:
v8-dev, Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

Do not allow invocation of ArrayBuffer and array buffer views' constructors as functions. ES6 bug 695 (https://bugs.ecmascript.org/show_bug.cgi?id=695). This never worked in WebKit, so no compatibility issues. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15346

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -58 lines) Patch
M src/arraybuffer.js View 1 chunk +1 line, -1 line 0 comments Download
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments Download
M src/typedarray.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/external-array.js View 2 chunks +11 lines, -26 lines 0 comments Download
M test/mjsunit/external-array-no-sse2.js View 2 chunks +11 lines, -26 lines 0 comments Download
M test/mjsunit/harmony/typedarrays.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-1383.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
7 years, 6 months ago (2013-06-26 18:48:49 UTC) #1
rossberg
lgtm
7 years, 6 months ago (2013-06-27 07:39:26 UTC) #2
Dmitry Lomov (no reviews)
7 years, 6 months ago (2013-06-27 07:42:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15346 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698