Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: gyp/SampleApp.gyp

Issue 17904006: Add an option to have a PdfViewer in SampleApp. Add a parameter --pdfDir to pass the dir with pdfs.… (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | samplecode/SampleApp.h » ('j') | samplecode/SampleApp.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/SampleApp.gyp
===================================================================
--- gyp/SampleApp.gyp (revision 9765)
+++ gyp/SampleApp.gyp (working copy)
@@ -1,4 +1,10 @@
{
+ 'variables': {
+ 'sample_pdf_file_viewer%': 0,
+ # set sample_pdf_file_viewer to 1 and uncomment next line too,
+ # podofo dependency has plenty of warnings in the header files that will be errors otherwise
+ #'skia_warnings_as_errors': 0,
vandebo (ex-Chrome) 2013/06/26 21:58:36 use a direct_dependent_settings section in order t
edisonn 2013/07/02 23:20:33 fixed (removed) On 2013/06/26 21:58:36, vandebo wr
+ },
'targets': [
{
'target_name': 'SampleApp',
@@ -151,7 +157,25 @@
'views_animated.gyp:views_animated',
'lua.gyp:lua',
],
- 'conditions' : [
+ 'conditions' : [
+ [ 'sample_pdf_file_viewer == 1', {
+ 'defines': [
+ 'SAMPLE_PDF_FILE_VIEWER',
+ ],
+ 'dependencies': [
+ 'pdfviewer.gyp:libpdfviewer',
+ ],
+ 'include_dirs' : [
+ '../third_party/externals/podofo/src/base',
+ '../third_party/externals/podofo/src',
+ '../third_party/externals/podofo',
+ '../experimental/PdfViewer',
+ '../experimental/PdfViewer/autogen',
+ ],
+ 'sources': [
+ '../samplecode/SamplePdfFileViewer.cpp',
+ ]
+ }],
[ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "chromeos"]', {
'sources!': [
'../samplecode/SampleDecode.cpp',
« no previous file with comments | « no previous file | samplecode/SampleApp.h » ('j') | samplecode/SampleApp.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698