Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 179032: Enable extensions by default. (Closed)

Created:
11 years, 3 months ago by Aaron Boodman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Enable extensions by default. BUG=20573 TEST=Install sample extensions without modifying command line flags. They should install (and run on next startup). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24846

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -49 lines) Patch
M chrome/browser/extensions/extension_browsertest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_startup_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_uitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extensions_service_unittest.cc View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/browser/profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +0 lines, -19 lines 1 comment Download
M chrome/browser/renderer_host/test/render_view_host_manager_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Aaron Boodman
11 years, 3 months ago (2009-08-28 23:32:38 UTC) #1
Erik does not do reviews
LGTM assuming the one question isn't an issue http://codereview.chromium.org/179032/diff/1/8 File chrome/browser/renderer_host/browser_render_process_host.cc (left): http://codereview.chromium.org/179032/diff/1/8#oldcode361 Line 361: ...
11 years, 3 months ago (2009-08-28 23:38:55 UTC) #2
Aaron Boodman
11 years, 3 months ago (2009-08-28 23:55:24 UTC) #3
On Fri, Aug 28, 2009 at 4:38 PM, <erikkay@chromium.org> wrote:
> http://codereview.chromium.org/179032/diff/1/8
> File chrome/browser/renderer_host/browser_render_process_host.cc (left):
>
> http://codereview.chromium.org/179032/diff/1/8#oldcode361
> Line 361: // Tell the renderer to enable extensions if there are any
> extensions loaded.
> do we need to explicitly pass along extensions-disabled to the renderer?

No, this is dead code. The renderer isn't using the flag anymore.

- a

Powered by Google App Engine
This is Rietveld 408576698