chrome/browser/extensions/extension_messages_unittest.cc - Issue 179027: Make a bunch of backlogged breaking changes to the extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_messages_unittest.cc

Issue 179027: Make a bunch of backlogged breaking changes to the extensions (Closed)

Patch Set: Put chrome.self back Created 11 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_messages_unittest.cc

diff --git a/chrome/browser/extensions/extension_messages_unittest.cc b/chrome/browser/extensions/extension_messages_unittest.cc

index aa6615c27b9da8d8a23d873ae9c64c04f257bbbc..824609720fc3a11e837bc07cce8267be39f52525 100644

--- a/chrome/browser/extensions/extension_messages_unittest.cc

+++ b/chrome/browser/extensions/extension_messages_unittest.cc

@@ -88,7 +88,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) {

TEST_F(RenderViewTest, ExtensionMessagesOnConnect) {

LoadHTML("<body></body>");

ExecuteJavaScript(

- "chrome.self.onConnect.addListener(function (port) {"

+ "chrome.extension.onConnect.addListener(function (port) {"

" port.test = 24;"

" port.onMessage.addListener(doOnMessage);"

" port.onDisconnect.addListener(doOnDisconnect);"

@@ -153,7 +153,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOnConnect) {

TEST_F(RenderViewTest, ExtensionMessagesDisconnect) {

LoadHTML("<body></body>");

ExecuteJavaScript(

- "chrome.self.onConnect.addListener(function (port) {"

+ "chrome.extension.onConnect.addListener(function (port) {"

" port.onMessage.addListener(function(msg, p) {"

" if (msg.disconnect) port.disconnect();"

" });"

@@ -161,7 +161,7 @@ TEST_F(RenderViewTest, ExtensionMessagesDisconnect) {

"var iframe1 = document.createElement('iframe');"

"var iframe2 = document.createElement('iframe');"

"var src = 'javascript:"

- " chrome.self.onConnect.addListener(function(port) {"

+ " chrome.extension.onConnect.addListener(function(port) {"

" port.postMessage(\"onconnect\");"

" port.onMessage.addListener(function(p) { alert(\"NOTREACHED\"); });"

" port.disconnect();"

« no previous file with comments | « no previous file | chrome/common/extensions/docs/static/background_pages.html » ('j') | no next file with comments »