Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 179022: gtk: Clip the tab title to the content height and not the font height. The f... (Closed)

Created:
11 years, 3 months ago by James Hawkins
Modified:
9 years, 7 months ago
Reviewers:
tony
CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)
Visibility:
Public.

Description

gtk: Clip the tab title to the content height and not the font height. The font height is a design measure and should not be used for a bounding box. BUG=20401 TEST=Open google.com in a tab. Tab title should be fully visible and not clipped. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/gtk/tabs/tab_renderer_gtk.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Hawkins
11 years, 3 months ago (2009-08-28 18:56:17 UTC) #1
tony
11 years, 3 months ago (2009-08-28 18:57:29 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698