Issue 179007: Rebaseline a couple of tests and update test_expecations.txt for a couple of ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179007: Rebaseline a couple of tests and update test_expecations.txt for a couple of ... (Closed)

Created:
11 years, 3 months ago by Nate Chapin

Modified:
9 years, 5 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, Pam (message me for reviews), darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Rebaseline a couple of tests and update test_expecations.txt for a couple of other issues as well. BUG=10398 TEST=green webkit builders Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24682

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -60 lines)			Patch
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-cancel-button-style-sharing-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-cancel-button-style-sharing-expected.png	View	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-cancel-button-style-sharing-expected.txt	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-rtl-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-rtl-expected.png	View	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-linux/LayoutTests/fast/forms/search-rtl-expected.txt	View	1 chunk	+59 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-cancel-button-style-sharing-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-cancel-button-style-sharing-expected.png	View	Binary file		0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-cancel-button-style-sharing-expected.txt	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-rtl-expected.checksum	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-rtl-expected.png	View	Binary file		0 comments	Download
M	webkit/data/layout_tests/platform/chromium-win/LayoutTests/fast/forms/search-rtl-expected.txt	View	1 chunk	+39 lines, -41 lines	0 comments	Download
	webkit/tools/layout_tests/test_expectations.txt	View	4 chunks	+6 lines, -19 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dglazkov

11 years, 3 months ago (2009-08-27 22:30:56 UTC) #2

LGTM, with comments (can submit after fixing):

http://codereview.chromium.org/179007/diff/1/2
File webkit/tools/layout_tests/test_expectations.txt (right):

http://codereview.chromium.org/179007/diff/1/2#newcode1621
Line 1621: BUG10385 : LayoutTests/fast/dom/dom-constructors.html = FAIL
Go ahead and move it to "OTHER" section, so that we don't re-analyze it. Can
remove the merge X:Y comment.

http://codereview.chromium.org/179007/diff/1/2#newcode1624
Line 1624: BUG10387 SKIP :
LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-image-not-loaded-svg.svg =
FAIL
Ditto.

Expand Messages | Collapse Messages