Add Help & feedback screens to Android Chromoting client

Add Help & feedback screens to Android Chromoting client

This adds a Help & feedback menu-item for each screen of the app. The
Help screen embeds a WebView, which shows a URL dependent on
which screen the Help was launched from.

There is also a Feedback menu-item, which is currently hidden, pending
implementation of this feature (only the Official build will have it).

A menu-item is provided for showing the Play Store entry for the
application. More menu-items can be added (such as Copyright,
Privacy policy, Open source licences) if they are required in the app.

BUG=333129
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253659

[Jamie, 2014-02-25 22:01:17]

LGTM with nits, but I'm no expert on this sort of thing.

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:51:
"http://support.google.com/chrome/?p=mobile_crd_hostslist";
When will this URL be live?

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/HelpActivity.java
(right):

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/HelpActivity.java:32: if
(intent.resolveActivity(getPackageManager()) != null) {
Is this scenario common enough that it's worth making the display of the Help
menu item contingent on it? I.e, don't offer Help if we can't provide it.

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/HelpActivity.java:76:
openUrl(PLAY_STORE_URL + getPackageName());
Will this open in the web browser or in the Google Play app?

https://codereview.chromium.org/179003006/diff/1/remoting/resources/android/m...
File remoting/resources/android/menu/chromoting_actionbar.xml (right):

https://codereview.chromium.org/179003006/diff/1/remoting/resources/android/m...
remoting/resources/android/menu/chromoting_actionbar.xml:14: 
Unnecessary change?

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:381: <message desc="Title displayed in
the action-bar for the Android Help screen" name="IDS_ACTIONBAR_HELP_TITLE"
formatter_data="android_java">
Make it clear in the description that this is a verb; e.g, append something
similar to what you have for the Feedback string: "Pressing this button gives
the user help on the current screen of the app."

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:385: Help &amp; feedback
Do we still need this one?

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:391: View in Google Play Store
Was this feature mandated by the UX review? It seems non-standard.

[Lambros, 2014-02-26 21:15:44]

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right):

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/Chromoting.java:51:
"http://support.google.com/chrome/?p=mobile_crd_hostslist";
On 2014/02/25 22:01:18, Jamie wrote:
> When will this URL be live?

The URL currently shows a generic Chrome Mobile help page, until our own help
content is written and published. That's in progress, but I don't know how long
that will take.

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
File remoting/android/java/src/org/chromium/chromoting/HelpActivity.java
(right):

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/HelpActivity.java:32: if
(intent.resolveActivity(getPackageManager()) != null) {
On 2014/02/25 22:01:18, Jamie wrote:
> Is this scenario common enough that it's worth making the display of the Help
> menu item contingent on it? I.e, don't offer Help if we can't provide it.

I can't see any supported device being unable to launch a web page (or the Play
Store app). This is just defensive coding! :)

https://codereview.chromium.org/179003006/diff/1/remoting/android/java/src/or...
remoting/android/java/src/org/chromium/chromoting/HelpActivity.java:76:
openUrl(PLAY_STORE_URL + getPackageName());
On 2014/02/25 22:01:18, Jamie wrote:
> Will this open in the web browser or in the Google Play app?

It opens the Play Store app.

https://codereview.chromium.org/179003006/diff/1/remoting/resources/android/m...
File remoting/resources/android/menu/chromoting_actionbar.xml (right):

https://codereview.chromium.org/179003006/diff/1/remoting/resources/android/m...
remoting/resources/android/menu/chromoting_actionbar.xml:14: 
On 2014/02/25 22:01:18, Jamie wrote:
> Unnecessary change?
Undone.

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
File remoting/resources/remoting_strings.grd (right):

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:381: <message desc="Title displayed in
the action-bar for the Android Help screen" name="IDS_ACTIONBAR_HELP_TITLE"
formatter_data="android_java">
On 2014/02/25 22:01:18, Jamie wrote:
> Make it clear in the description that this is a verb; e.g, append something
> similar to what you have for the Feedback string: "Pressing this button gives
> the user help on the current screen of the app."

It's the title of the Help & feedback screen - just the word "Help".

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:385: Help &amp; feedback
On 2014/02/25 22:01:18, Jamie wrote:
> Do we still need this one?

Yes, this is unchanged.

https://codereview.chromium.org/179003006/diff/1/remoting/resources/remoting_...
remoting/resources/remoting_strings.grd:391: View in Google Play Store
On 2014/02/25 22:01:18, Jamie wrote:
> Was this feature mandated by the UX review? It seems non-standard.

Yes, I think it's new. Haven't seen it in other apps, but it's described in our
guidelines.

[Lambros, 2014-02-26 23:26:23]

The CQ bit was checked by lambroslambrou@chromium.org

[commit-bot: I haz the power, 2014-02-26 23:32:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/179003006/...

[commit-bot: I haz the power, 2014-02-27 00:29:20]

Change committed as 253659