Issue 179003: Add a fast path for tab strip expose.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 179003: Add a fast path for tab strip expose. (Closed)

Created:
11 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews_googlegroups.com, Evan Martin

Visibility:
Public.

Description

Add a fast path for tab strip expose. This optimizes the common case of just needing to update favicons. If the expose area consists of just favicons, only paint the favicons (i.e., don't bother with the complex tab edges that overlap). This doesn't help when tabs are resizing or moving, but does reduce CPU usage quite a bit. BUG=15872

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -2 lines)			Patch
M	chrome/browser/gtk/tabs/tab_renderer_gtk.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_renderer_gtk.cc	View		3 chunks	+43 lines, -1 line	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/tabs/tab_strip_gtk.cc	View		4 chunks	+59 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

tony

Here are pprof graphs from before and after the change: http://ponderer.org/tests/perf/tabstrip-before.ps http://ponderer.org/tests/perf/tabstrip-after.ps This is with ...

11 years, 3 months ago (2009-08-27 21:11:38 UTC) #1

James Hawkins

11 years, 3 months ago (2009-08-27 21:22:52 UTC) #2

LGTM

http://codereview.chromium.org/179003/diff/1/5
File chrome/browser/gtk/tabs/tab_strip_gtk.h (right):

http://codereview.chromium.org/179003/diff/1/5#newcode254
Line 254: // Returns true of |rects| are all areas that match up with tab
favicons.
s/of/if/ ?

Expand Messages | Collapse Messages