Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 178993006: Convolver.SIMDVerification has been replaced with two smaller tests. (Closed)

Created:
6 years, 10 months ago by hubbe
Modified:
6 years, 9 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Convolver.SIMDVerification has been replaced with two smaller tests. (https://codereview.chromium.org/178013006/) Clean up the memcheck and tsan tool filters accordingly. BUG=134400 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M tools/valgrind/gtest_exclude/unit_tests.gtest-memcheck.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/valgrind/gtest_exclude/unit_tests.gtest-tsan.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
hubbe
6 years, 10 months ago (2014-02-26 19:14:12 UTC) #1
hubbe
6 years, 10 months ago (2014-02-26 19:15:04 UTC) #2
Stephen White
LGTM, but I'm trusting you that it's not slow. :)
6 years, 10 months ago (2014-02-26 19:16:05 UTC) #3
hubbe
On 2014/02/26 19:16:05, Stephen White wrote: > LGTM, but I'm trusting you that it's not ...
6 years, 10 months ago (2014-02-26 19:24:16 UTC) #4
hubbe
The CQ bit was checked by hubbe@chromium.org
6 years, 10 months ago (2014-02-26 19:24:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/178993006/1
6 years, 10 months ago (2014-02-26 19:25:11 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-26 22:41:55 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=270724
6 years, 10 months ago (2014-02-26 22:41:55 UTC) #8
hubbe
The CQ bit was checked by hubbe@chromium.org
6 years, 9 months ago (2014-02-27 17:37:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/178993006/1
6 years, 9 months ago (2014-02-27 17:37:38 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 19:05:26 UTC) #11
Message was sent while issue was closed.
Change committed as 253890

Powered by Google App Engine
This is Rietveld 408576698