Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1789663003: Index synthetic top-level variable and 'loadLibrary' references. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Index synthetic top-level variable and 'loadLibrary' references. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/10401887696404b55610143a2d04a892dd4ef613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +11 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/index_unit.dart View 1 chunk +10 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/index_unit_test.dart View 3 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-11 18:34:34 UTC) #1
Brian Wilkerson
LGTM
4 years, 9 months ago (2016-03-11 18:36:17 UTC) #2
scheglov
4 years, 9 months ago (2016-03-11 18:43:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10401887696404b55610143a2d04a892dd4ef613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698