Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1789633004: Option support for enableStrictCallChecks (#25983) (Closed)

Created:
4 years, 9 months ago by pquitslund
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M pkg/analyzer/lib/src/task/options.dart View 3 chunks +12 lines, -2 lines 1 comment Download
M pkg/analyzer/test/src/task/options_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pquitslund
4 years, 9 months ago (2016-03-11 22:36:26 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1789633004/diff/1/pkg/analyzer/lib/src/task/options.dart File pkg/analyzer/lib/src/task/options.dart (right): https://codereview.chromium.org/1789633004/diff/1/pkg/analyzer/lib/src/task/options.dart#newcode485 pkg/analyzer/lib/src/task/options.dart:485: new AnalysisOptionsImpl.from(context.analysisOptions); format?
4 years, 9 months ago (2016-03-11 22:45:02 UTC) #3
pquitslund
On 2016/03/11 22:45:02, Brian Wilkerson wrote: > LGTM > > https://codereview.chromium.org/1789633004/diff/1/pkg/analyzer/lib/src/task/options.dart > File pkg/analyzer/lib/src/task/options.dart (right): ...
4 years, 9 months ago (2016-03-11 22:47:14 UTC) #4
pquitslund
Thanks!
4 years, 9 months ago (2016-03-11 22:47:22 UTC) #5
pquitslund
4 years, 9 months ago (2016-03-11 22:48:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
549b20db7bb3460f16a114ec433329e5abf55dd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698