Add DependentCode to PropertyCells

Add DependentCode to PropertyCells

R=mstarzinger@chromium.org, ulan@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=15341

[danno, 2013-06-26 15:02:46]

PTAL

Michael, can you take a quick look at the StaticMarkingVisitor changes for
PropertyCell?

[Michael Starzinger, 2013-06-26 15:23:31]

Looking good, I reviewed "heap", "mark-compact" and "objects-visiting" files.
Just a two minor comments. Let me know if I need to review the rest as well.

https://codereview.chromium.org/17895004/diff/6001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/17895004/diff/6001/src/mark-compact.cc#newcod...
src/mark-compact.cc:2445:
ClearNonLiveDependentCode(PropertyCell::cast(cell)->dependent_code());
This iteration should only concern itself with marked property cells, unmarked
cells should be safe to ignore.

https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):

https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h...
src/objects-visiting-inl.h:366: // ClearNonLivePropertyCellCodeDependencies.
nit: Comment is outdated, the function is called ClearNonLiveReferences().

[Michael Starzinger, 2013-06-26 15:32:03]

One more comment ...

https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):

https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h...
src/objects-visiting-inl.h:366: // ClearNonLivePropertyCellCodeDependencies.
On 2013/06/26 15:23:31, Michael Starzinger wrote:
> nit: Comment is outdated, the function is called ClearNonLiveReferences().

Also the cleanup pass is only done with FLAG_collect_maps, so this block needs
to be guarded by this flag was well.

[ulan, 2013-06-26 15:34:56]

> I reviewed "heap", "mark-compact" and "objects-visiting" files.
The rest LGTM.

[danno, 2013-06-26 15:42:40]

Feedback addresses, please take another look

https://codereview.chromium.org/17895004/diff/6001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://codereview.chromium.org/17895004/diff/6001/src/mark-compact.cc#newcod...
src/mark-compact.cc:2445:
ClearNonLiveDependentCode(PropertyCell::cast(cell)->dependent_code());
On 2013/06/26 15:23:31, Michael Starzinger wrote:
> This iteration should only concern itself with marked property cells, unmarked
> cells should be safe to ignore.

Done.

https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h
File src/objects-visiting-inl.h (right):

https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h...
src/objects-visiting-inl.h:366: // ClearNonLivePropertyCellCodeDependencies.
On 2013/06/26 15:23:31, Michael Starzinger wrote:
> nit: Comment is outdated, the function is called ClearNonLiveReferences().

Done.

https://codereview.chromium.org/17895004/diff/6001/src/objects-visiting-inl.h...
src/objects-visiting-inl.h:366: // ClearNonLivePropertyCellCodeDependencies.
On 2013/06/26 15:23:31, Michael Starzinger wrote:
> nit: Comment is outdated, the function is called ClearNonLiveReferences().

Done.

[Michael Starzinger, 2013-06-26 16:11:59]

LGTM from my end as well.

[danno, 2013-06-26 16:17:23]

Committed patchset #5 manually as r15341 (presubmit successful).