Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Side by Side Diff: src/ia32/macro-assembler-ia32.cc

Issue 17895002: The check for internalized strings relied on the fact that we had less (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: More comments Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2789 matching lines...) Expand 10 before | Expand all | Expand 10 after
2800 // Interleave bits from both instance types and compare them in one check. 2800 // Interleave bits from both instance types and compare them in one check.
2801 ASSERT_EQ(0, kFlatAsciiStringMask & (kFlatAsciiStringMask << 3)); 2801 ASSERT_EQ(0, kFlatAsciiStringMask & (kFlatAsciiStringMask << 3));
2802 and_(scratch1, kFlatAsciiStringMask); 2802 and_(scratch1, kFlatAsciiStringMask);
2803 and_(scratch2, kFlatAsciiStringMask); 2803 and_(scratch2, kFlatAsciiStringMask);
2804 lea(scratch1, Operand(scratch1, scratch2, times_8, 0)); 2804 lea(scratch1, Operand(scratch1, scratch2, times_8, 0));
2805 cmp(scratch1, kFlatAsciiStringTag | (kFlatAsciiStringTag << 3)); 2805 cmp(scratch1, kFlatAsciiStringTag | (kFlatAsciiStringTag << 3));
2806 j(not_equal, failure); 2806 j(not_equal, failure);
2807 } 2807 }
2808 2808
2809 2809
2810 void MacroAssembler::JumpIfNotUniqueName(Operand operand,
2811 Label* not_unique_name,
2812 Label::Distance distance) {
2813 STATIC_ASSERT(((SYMBOL_TYPE - 1) & kIsInternalizedMask) == kInternalizedTag);
2814 cmp(operand, Immediate(kInternalizedTag));
2815 j(less, not_unique_name, distance);
2816 cmp(operand, Immediate(SYMBOL_TYPE));
2817 j(greater, not_unique_name, distance);
2818 }
2819
2820
2810 void MacroAssembler::PrepareCallCFunction(int num_arguments, Register scratch) { 2821 void MacroAssembler::PrepareCallCFunction(int num_arguments, Register scratch) {
2811 int frame_alignment = OS::ActivationFrameAlignment(); 2822 int frame_alignment = OS::ActivationFrameAlignment();
2812 if (frame_alignment != 0) { 2823 if (frame_alignment != 0) {
2813 // Make stack end at alignment and make room for num_arguments words 2824 // Make stack end at alignment and make room for num_arguments words
2814 // and the original value of esp. 2825 // and the original value of esp.
2815 mov(scratch, esp); 2826 mov(scratch, esp);
2816 sub(esp, Immediate((num_arguments + 1) * kPointerSize)); 2827 sub(esp, Immediate((num_arguments + 1) * kPointerSize));
2817 ASSERT(IsPowerOf2(frame_alignment)); 2828 ASSERT(IsPowerOf2(frame_alignment));
2818 and_(esp, -frame_alignment); 2829 and_(esp, -frame_alignment);
2819 mov(Operand(esp, num_arguments * kPointerSize), scratch); 2830 mov(Operand(esp, num_arguments * kPointerSize), scratch);
(...skipping 348 matching lines...) Expand 10 before | Expand all | Expand 10 after
3168 j(greater, &no_info_available); 3179 j(greater, &no_info_available);
3169 cmp(MemOperand(scratch_reg, -AllocationSiteInfo::kSize), 3180 cmp(MemOperand(scratch_reg, -AllocationSiteInfo::kSize),
3170 Immediate(Handle<Map>(isolate()->heap()->allocation_site_info_map()))); 3181 Immediate(Handle<Map>(isolate()->heap()->allocation_site_info_map())));
3171 bind(&no_info_available); 3182 bind(&no_info_available);
3172 } 3183 }
3173 3184
3174 3185
3175 } } // namespace v8::internal 3186 } } // namespace v8::internal
3176 3187
3177 #endif // V8_TARGET_ARCH_IA32 3188 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/macro-assembler-ia32.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698