Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 1789493002: Add lang="ja" to some Japanese tests to make results more sensible (Closed)

Created:
4 years, 9 months ago by kojii
Modified:
4 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add lang="ja" to some Japanese tests to make results more sensible This patch adds lang="ja" to 3 more tests that use Japanese text. Han ideographic characters are rendered in Chinese fonts by default if without the lang attribute on English Windows. By adding lang="ja", they are rendered in Japanese fonts, and it makes the image results closer to what users would see. This was done to several tests in crbug.com/379189, but crrev.com/380435 revealed there are 3 more. BUG=593917, 574660 Committed: https://crrev.com/e603c9bfee03225f5212b1f576423d7fb264b2de Cr-Commit-Position: refs/heads/master@{#380591}

Patch Set 1 #

Patch Set 2 : Add font-family #

Patch Set 3 : NeedsRebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/emphasis-vertical.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/japanese-lr-selection.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/japanese-rl-selection.html View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
kojii
PTAL.
4 years, 9 months ago (2016-03-11 08:04:29 UTC) #6
tkent
lgtm
4 years, 9 months ago (2016-03-11 08:07:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789493002/40001
4 years, 9 months ago (2016-03-11 09:05:05 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-11 10:21:34 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-11 10:22:31 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e603c9bfee03225f5212b1f576423d7fb264b2de
Cr-Commit-Position: refs/heads/master@{#380591}

Powered by Google App Engine
This is Rietveld 408576698