Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1789433002: [Sync] Start up immediately when entering the sync setup UI. (Closed)

Created:
4 years, 9 months ago by maxbogue
Modified:
4 years, 9 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@setup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Start up immediately when entering the sync setup UI. BUG=593998 Committed: https://crrev.com/8f6547375c2cb3d8b41d70b967dfbea6ab3d36b9 Cr-Commit-Position: refs/heads/master@{#381313}

Patch Set 1 #

Total comments: 7

Patch Set 2 : Split tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -12 lines) Patch
M components/browser_sync/browser/profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync_driver/startup_controller.h View 2 chunks +4 lines, -2 lines 0 comments Download
M components/sync_driver/startup_controller.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M components/sync_driver/startup_controller_unittest.cc View 1 3 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
maxbogue
Nicolas, PTAL!
4 years, 9 months ago (2016-03-11 17:37:45 UTC) #2
Nicolas Zea
Nice find! https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/startup_controller.cc File components/sync_driver/startup_controller.cc (right): https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/startup_controller.cc#newcode84 components/sync_driver/startup_controller.cc:84: TryStart(); What happens if Chrome is already ...
4 years, 9 months ago (2016-03-14 22:42:01 UTC) #3
maxbogue
PTAL https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/startup_controller.cc File components/sync_driver/startup_controller.cc (right): https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/startup_controller.cc#newcode84 components/sync_driver/startup_controller.cc:84: TryStart(); On 2016/03/14 22:42:01, Nicolas Zea wrote: > ...
4 years, 9 months ago (2016-03-15 17:41:01 UTC) #4
Nicolas Zea
LGTM! https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/startup_controller.cc File components/sync_driver/startup_controller.cc (right): https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/startup_controller.cc#newcode84 components/sync_driver/startup_controller.cc:84: TryStart(); On 2016/03/15 17:41:01, maxbogue wrote: > On ...
4 years, 9 months ago (2016-03-15 18:16:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1789433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1789433002/20001
4 years, 9 months ago (2016-03-15 20:35:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-15 21:07:42 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 21:09:06 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f6547375c2cb3d8b41d70b967dfbea6ab3d36b9
Cr-Commit-Position: refs/heads/master@{#381313}

Powered by Google App Engine
This is Rietveld 408576698