[Sync] Start up immediately when entering the sync setup UI.

[Sync] Start up immediately when entering the sync setup UI.

BUG=593998
Committed: https://crrev.com/8f6547375c2cb3d8b41d70b967dfbea6ab3d36b9
Cr-Commit-Position: refs/heads/master@{#381313}

[maxbogue, 2016-03-11 17:37:45]

maxbogue@chromium.org changed reviewers:
+ zea@chromium.org

[maxbogue, 2016-03-11 17:37:45]

Nicolas, PTAL!

[Nicolas Zea, 2016-03-14 22:42:01]

Nice find!

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
File components/sync_driver/startup_controller.cc (right):

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
components/sync_driver/startup_controller.cc:84: TryStart();
What happens if Chrome is already started? Can this have any negative effects?

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
File components/sync_driver/startup_controller_unittest.cc (right):

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
components/sync_driver/startup_controller_unittest.cc:180: // Test interrupting
a deferred start.
Maybe split this into two separate tests?

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
components/sync_driver/startup_controller_unittest.cc:249: // Test interrupting
a deferred start.
This also seems like it could be two different tests.

[maxbogue, 2016-03-15 17:41:01]

PTAL

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
File components/sync_driver/startup_controller.cc (right):

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
components/sync_driver/startup_controller.cc:84: TryStart();
On 2016/03/14 22:42:01, Nicolas Zea wrote:
> What happens if Chrome is already started? Can this have any negative effects?

Assuming you meant s/Chrome/sync, no, it will not do anything. The
|start_backend_time_| value acts as a barrier to StartupController starting sync
more than once before being reset.

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
File components/sync_driver/startup_controller_unittest.cc (right):

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
components/sync_driver/startup_controller_unittest.cc:180: // Test interrupting
a deferred start.
On 2016/03/14 22:42:01, Nicolas Zea wrote:
> Maybe split this into two separate tests?

Done.

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
components/sync_driver/startup_controller_unittest.cc:249: // Test interrupting
a deferred start.
On 2016/03/14 22:42:01, Nicolas Zea wrote:
> This also seems like it could be two different tests.

Done.

[Nicolas Zea, 2016-03-15 18:16:14]

LGTM!

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
File components/sync_driver/startup_controller.cc (right):

https://codereview.chromium.org/1789433002/diff/1/components/sync_driver/star...
components/sync_driver/startup_controller.cc:84: TryStart();
On 2016/03/15 17:41:01, maxbogue wrote:
> On 2016/03/14 22:42:01, Nicolas Zea wrote:
> > What happens if Chrome is already started? Can this have any negative
effects?
> 
> Assuming you meant s/Chrome/sync, no, it will not do anything. The
> |start_backend_time_| value acts as a barrier to StartupController starting
sync
> more than once before being reset.

Acknowledged.

[maxbogue, 2016-03-15 20:35:37]

The CQ bit was checked by maxbogue@chromium.org

[commit-bot: I haz the power, 2016-03-15 20:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1789433002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1789433002/20001

[commit-bot: I haz the power, 2016-03-15 21:07:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-15 21:09:05]

Description was changed from

==========
[Sync] Start up immediately when entering the sync setup UI.

BUG=593998
==========

to

==========
[Sync] Start up immediately when entering the sync setup UI.

BUG=593998

Committed: https://crrev.com/8f6547375c2cb3d8b41d70b967dfbea6ab3d36b9
Cr-Commit-Position: refs/heads/master@{#381313}
==========

[commit-bot: I haz the power, 2016-03-15 21:09:06]

Patchset 2 (id:??) landed as
https://crrev.com/8f6547375c2cb3d8b41d70b967dfbea6ab3d36b9
Cr-Commit-Position: refs/heads/master@{#381313}