Adding parser layout test for whitespace around comma in argument list

Adding parser layout test for whitespace around comma in argument list

Imported webkit testcase from here:
https://bugs.webkit.org/show_bug.cgi?id=77773

Appears issues is already fixed in blink, so no code changes required.

BUG=231630
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167737

[rwlbuis, 2014-02-24 22:55:41]

Test looks good but indentation should be fixed. Great that the actual bug is
fixed.

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
File LayoutTests/svg/parser/svg-parser-argument-whitespace.html (right):

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
LayoutTests/svg/parser/svg-parser-argument-whitespace.html:5: 
The does not need to be an empty line here.

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
LayoutTests/svg/parser/svg-parser-argument-whitespace.html:11: <rect id="myRect"
x="50" y="50" width="100" height="100" fill="green"
Indenting seems wrong here. It is better to avoid tabs in general.

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
LayoutTests/svg/parser/svg-parser-argument-whitespace.html:14: 
Ditto.

[rwlbuis, 2014-02-24 22:59:44]

On 2014/02/24 22:55:41, rwlbuis wrote:
> Test looks good but indentation should be fixed. Great that the actual bug is
> fixed.
> 
>
https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
> File LayoutTests/svg/parser/svg-parser-argument-whitespace.html (right):
> 
>
https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
> LayoutTests/svg/parser/svg-parser-argument-whitespace.html:5: 
> The does not need to be an empty line here.
> 
>
https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
> LayoutTests/svg/parser/svg-parser-argument-whitespace.html:11: <rect
id="myRect"
> x="50" y="50" width="100" height="100" fill="green"
> Indenting seems wrong here. It is better to avoid tabs in general.
> 
>
https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
> LayoutTests/svg/parser/svg-parser-argument-whitespace.html:14: 
> Ditto.

One more thing, I think the description could be better. Instead of "patch" you
should say "testcase" to avoid confusion.
Also you should mention that we pass the original testcase, so no code changes
needed.

[ostap, 2014-02-24 23:28:18]

Patch and description updated.

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
File LayoutTests/svg/parser/svg-parser-argument-whitespace.html (right):

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
LayoutTests/svg/parser/svg-parser-argument-whitespace.html:5: 
On 2014/02/24 22:55:41, rwlbuis wrote:
> The does not need to be an empty line here.

Done.

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
LayoutTests/svg/parser/svg-parser-argument-whitespace.html:11: <rect id="myRect"
x="50" y="50" width="100" height="100" fill="green"
On 2014/02/24 22:55:41, rwlbuis wrote:
> Indenting seems wrong here. It is better to avoid tabs in general.

Done.

https://codereview.chromium.org/178943002/diff/1/LayoutTests/svg/parser/svg-p...
LayoutTests/svg/parser/svg-parser-argument-whitespace.html:14: 
On 2014/02/24 22:55:41, rwlbuis wrote:
> Ditto.

Done.

[rwlbuis, 2014-02-24 23:31:20]

lgtm

[ostap, 2014-02-24 23:36:18]

The CQ bit was checked by sl.ostapenko@samsung.com

[commit-bot: I haz the power, 2014-02-24 23:36:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/178943002/20001

[commit-bot: I haz the power, 2014-02-25 01:10:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/178943002/20001

[commit-bot: I haz the power, 2014-02-25 05:18:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/178943002/20001

[commit-bot: I haz the power, 2014-02-25 06:54:47]

Change committed as 167737