Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 17893010: In components/autofill, move notification handling into content driver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Response to review Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate.h
diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h
index 7dde4e400e65869bad1653236e9bd5dfd9db0ae7..e6631acfba1218f57a97419e66d1d30b92941dca 100644
--- a/components/autofill/core/browser/autofill_external_delegate.h
+++ b/components/autofill/core/browser/autofill_external_delegate.h
@@ -15,8 +15,6 @@
#include "components/autofill/core/common/form_data.h"
#include "components/autofill/core/common/form_field_data.h"
#include "components/autofill/core/common/password_form_fill_data.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
#include "ui/gfx/rect.h"
namespace gfx {
@@ -38,8 +36,7 @@ class AutofillManager;
// Delegate for in-browser Autocomplete and Autofill display and selection.
class AutofillExternalDelegate
- : public content::NotificationObserver,
- public AutofillPopupDelegate {
+ : public AutofillPopupDelegate {
public:
// Creates an AutofillExternalDelegate for the specified contents; the second
// argument is an AutofillManager managing Autofill for that WebContents.
@@ -138,11 +135,6 @@ class AutofillExternalDelegate
std::vector<base::string16>* autofill_icons,
std::vector<int>* autofill_unique_ids);
- // content::NotificationObserver method override.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
// The web_contents associated with this delegate.
content::WebContents* web_contents_; // weak; owns me.
AutofillManager* autofill_manager_; // weak.
@@ -154,9 +146,6 @@ class AutofillExternalDelegate
// out of date responses.
int autofill_query_id_;
- // A scoped container for notification registries.
- content::NotificationRegistrar registrar_;
-
// The current form and field selected by Autofill.
FormData autofill_query_form_;
FormFieldData autofill_query_field_;
« no previous file with comments | « components/autofill/core/browser/DEPS ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698